New issue
Advanced search Search tips

Issue 607698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 606065



Sign in to add a comment

Merge request for uma metrics in beta

Project Member Reported by dmu...@chromium.org, Apr 28 2016

Issue description

I need a dependency uma metric patch pushed to beta, before I disable crashing (in https://bugs.chromium.org/p/chromium/issues/detail?id=606065)

This is the patch, and it's been in Canary for about a week
https://codereview.chromium.org/1893293006
 

Comment 1 by dmu...@chromium.org, Apr 29 2016

Blocking: 606065

Comment 2 by tin...@google.com, Apr 29 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 29 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0440e2b94ca72b49ce5a2bc45f814033b092d1f

commit e0440e2b94ca72b49ce5a2bc45f814033b092d1f
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Apr 29 21:23:40 2016

[Blob] Added error reporting metrics to invalid message errors.

This helps us get to the bottom of where the invalid blob refcount
and url calls are. It's unclear whether these are new or if they've
always occurred, as we used to ignore these messages.

R=kinuko@chromium.org, mpearson@chromium.org
BUG= 602443 , 607698 

Review URL: https://codereview.chromium.org/1893293006

Cr-Commit-Position: refs/heads/master@{#388626}
(cherry picked from commit a00379794f50019c7047c83e537803b7ba2b11ea)

Review URL: https://codereview.chromium.org/1940623002 .

Cr-Commit-Position: refs/branch-heads/2704@{#317}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/e0440e2b94ca72b49ce5a2bc45f814033b092d1f/tools/metrics/histograms/histograms.xml

Comment 4 by dmu...@chromium.org, Apr 29 2016

Status: Fixed (was: Assigned)
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI

Sign in to add a comment