New issue
Advanced search Search tips

Issue 607693 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal should check if the proxy_info is for a DataReductionProxy server and early return.

Project Member Reported by ryansturm@chromium.org, Apr 28 2016

Issue description

DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal is only called in the case where a proxy is being used (see HttpNetworkTransaction::UsingHttpProxyWithoutTunnel). The NetworkDelegate should explicitly check if the proxy_server in proxy_info is a DataReductionProxy, and it should not run any code in the case that is not a DataReductionProxy.

Any code that needs to run in either case should be called in OnBeforeSendHeadersInternal. If this is not possible due to timing (SetLoFiModeActiveOnMainFrame might need to be called in either case), the lofi bool added to DataReductionProxyData in URLRequest's UserData can be used to make an evaluation in OnSendHeadersInternal. 
 

Comment 1 Deleted

Comment 2 Deleted

Cc: bengr@chromium.org
Owner: ----
Status: (was: Assigned)
Making available for reassignment 
Status: Available
Components: Internals>Network>DataProxy

Comment 6 by bengr@chromium.org, Dec 1 2017

Refreshed during triage.
Status: Fixed (was: Available)
This got fixed a year and a half ago. ¯\_(ツ)_/¯

See https://codereview.chromium.org/1933653004 which didn't update the bug when it landed: 

Sign in to add a comment