DataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal should check if the proxy_info is for a DataReductionProxy server and early return. |
|||||
Issue descriptionDataReductionProxyNetworkDelegate::OnBeforeSendProxyHeadersInternal is only called in the case where a proxy is being used (see HttpNetworkTransaction::UsingHttpProxyWithoutTunnel). The NetworkDelegate should explicitly check if the proxy_server in proxy_info is a DataReductionProxy, and it should not run any code in the case that is not a DataReductionProxy. Any code that needs to run in either case should be called in OnBeforeSendHeadersInternal. If this is not possible due to timing (SetLoFiModeActiveOnMainFrame might need to be called in either case), the lofi bool added to DataReductionProxyData in URLRequest's UserData can be used to make an evaluation in OnSendHeadersInternal.
,
Oct 4 2017
Making available for reassignment
,
Oct 4 2017
,
Oct 5 2017
,
Dec 1 2017
Refreshed during triage.
,
Dec 1 2017
This got fixed a year and a half ago. ¯\_(ツ)_/¯ See https://codereview.chromium.org/1933653004 which didn't update the bug when it landed: |
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted