New issue
Advanced search Search tips

Issue 607690 link

Starred by 5 users
Status: Verified
Owner:
einbinder@chromium.org
Closed: Mar 2017
Cc:
l...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Console - bring codemirror features to the console readline

Project Member Reported by paulir...@chromium.org, Apr 28 2016 
We want:
* automatic insertion of brackets and visual bracket highlighting
* live syntax highlighting on the readline


Codemirror can give us these for free, though it'll take a bit of work to use in this place.

Webkit has been using it in this capacity for a while. https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js
Screen Shot 2016-04-28 at 2.02.44 PM.png
53.6 KB View Download
webkit.png
6.4 KB View Download

Comment 1 by l...@chromium.org, Jul 15 2016

Cc: einbinder@chromium.org

Comment 2 by l...@chromium.org, Jul 16 2016

Cc: -einbinder@chromium.org l...@chromium.org
Owner: einbinder@chromium.org
Summary: DevTools: Console - bring codemirror features to the console readline (was: DevTools: Console - use codemirror on the console readline)
Another feature CM provides is their undo/redo, which is currently broken on stable.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94618bb52b07b3c367e2ea52fc16e9352c20b44

commit c94618bb52b07b3c367e2ea52fc16e9352c20b44
Author: einbinder <einbinder@chromium.org>
Date: Tue Aug 23 22:46:15 2016

DevTools: Split off SourcesTextEditor from CodeMirrorTextEditor
This is in preperation for CodeMirror-based console

BUG= 607690 

Review-Url: https://codereview.chromium.org/2238883004
Cr-Commit-Position: refs/heads/master@{#413873}

[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/LayoutTests/inspector/editor/editor-test.js
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/LayoutTests/inspector/editor/text-editor-indent-autodetection.html
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-js-line-level-profile.html
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[add] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/front_end/source_frame/module.json
[modify] https://crrev.com/c94618bb52b07b3c367e2ea52fc16e9352c20b44/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4beff26238184abd3d3b6cde0fcda863f2a9300a

commit 4beff26238184abd3d3b6cde0fcda863f2a9300a
Author: einbinder <einbinder@chromium.org>
Date: Wed Aug 24 22:19:09 2016

DevTools: Merge CodeMirrorTextEditor's copyRange into text
This is in preperation for CodeMirror-based console

BUG= 607690 

Review-Url: https://codereview.chromium.org/2269183003
Cr-Commit-Position: refs/heads/master@{#414171}

[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-search.html
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/LayoutTests/inspector/editor/editor-test.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/LayoutTests/inspector/editor/text-editor-word-jumps.html
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/4beff26238184abd3d3b6cde0fcda863f2a9300a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b39cdf5665a652c50824367829c2bbff8cdfdd1

commit 3b39cdf5665a652c50824367829c2bbff8cdfdd1
Author: einbinder <einbinder@chromium.org>
Date: Fri Aug 26 17:27:28 2016

DevTools: Move CodeMirrorTextEditor into text_editor module
This is in preperation for CodeMirror-based console

BUG= 607690 
NOTRY=true

Review-Url: https://codereview.chromium.org/2271683003
Cr-Commit-Position: refs/heads/master@{#414740}

[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/devtools.gyp
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/devtools.gypi
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/cm_modes/module.json
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/source_frame/module.json
[rename] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[rename] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorUtils.js
[rename] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
[rename] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css
[add] https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1/third_party/WebKit/Source/devtools/front_end/text_editor/module.json
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8552fb6d3ad03924ec0da93e647044e9158b226

commit b8552fb6d3ad03924ec0da93e647044e9158b226
Author: einbinder <einbinder@chromium.org>
Date: Tue Sep 06 23:34:18 2016

DevTools: Create TextEditor Interface around CodeMirrorTextEditor
This is for lazy loading of the text_editor module in preperation of CodeMirror-based console.

BUG= 607690 

Review-Url: https://codereview.chromium.org/2281703002
Cr-Commit-Position: refs/heads/master@{#416774}

[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/text_editor/module.json
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
[add] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js
[modify] https://crrev.com/b8552fb6d3ad03924ec0da93e647044e9158b226/third_party/WebKit/Source/devtools/front_end/ui/module.json
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfd101e48d3242aed02f6209790e2687915237e5

commit bfd101e48d3242aed02f6209790e2687915237e5
Author: einbinder <einbinder@chromium.org>
Date: Mon Sep 12 22:05:55 2016

DevTools: Allow PageUp to fall through text editor
This is in preperation of CodeMirror-based console prompt.

BUG= 607690 

Review-Url: https://codereview.chromium.org/2332013002
Cr-Commit-Position: refs/heads/master@{#418072}

[modify] https://crrev.com/bfd101e48d3242aed02f6209790e2687915237e5/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[modify] https://crrev.com/bfd101e48d3242aed02f6209790e2687915237e5/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd9f42976b2d7c512f5242dffe713bfa06c22a9c

commit fd9f42976b2d7c512f5242dffe713bfa06c22a9c
Author: einbinder <einbinder@chromium.org>
Date: Fri Sep 16 22:33:42 2016

DevTools: Implement the console prompt with CodeMirror

BUG= 607690 

Review-Url: https://codereview.chromium.org/2331053002
Cr-Commit-Position: refs/heads/master@{#419305}

[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[delete] https://crrev.com/e0f27b9808ea6a7333669e2404be671fd4231d00/third_party/WebKit/LayoutTests/inspector/console/console-auto-completion-expected.txt
[delete] https://crrev.com/e0f27b9808ea6a7333669e2404be671fd4231d00/third_party/WebKit/LayoutTests/inspector/console/console-auto-completion.html
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/Tests.js
[add] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
[modify] https://crrev.com/fd9f42976b2d7c512f5242dffe713bfa06c22a9c/third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js

Comment 10 by l446240525@gmail.com, Sep 19 2016 

Ctrl-A/Ctrl-E do not work anymore, could you please fix it?

Comment 11 by einbinder@chromium.org, Mar 17 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment