Offline Pages: OfflinePageTabHelper relies on synchronous APIs. |
|||
Issue descriptionAs part of the Offline Pages API project, we are making our model asynchronous. The OfflinePageTabHelper uses the following deprecated APIs: OfflinePageUtils::GetOfflineURLForOnlineURL OfflinePageUtils::GetOnlineURLForOfflineURL These will need to be updated to support the asynchronous offline model, possibly affecting the design of the UI class.
,
Jun 17 2016
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44d11cb4bed3575d3c89abae66b61d6f76f221f8 commit 44d11cb4bed3575d3c89abae66b61d6f76f221f8 Author: dewittj <dewittj@chromium.org> Date: Fri Jun 17 23:30:28 2016 Refactors offline page tab helper to stash the offline page item on redirect. This allows the Tab to pull the offline page item synchronously when it's rendering the omnibox UI. BUG= 607684 Review-Url: https://codereview.chromium.org/2040163003 Cr-Commit-Position: refs/heads/master@{#400542} [modify] https://crrev.com/44d11cb4bed3575d3c89abae66b61d6f76f221f8/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/44d11cb4bed3575d3c89abae66b61d6f76f221f8/chrome/browser/android/offline_pages/offline_page_tab_helper.h [modify] https://crrev.com/44d11cb4bed3575d3c89abae66b61d6f76f221f8/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc [modify] https://crrev.com/44d11cb4bed3575d3c89abae66b61d6f76f221f8/chrome/browser/android/offline_pages/offline_page_utils.cc [modify] https://crrev.com/44d11cb4bed3575d3c89abae66b61d6f76f221f8/chrome/browser/android/offline_pages/offline_page_utils.h
,
Sep 27 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fgor...@chromium.org
, May 11 2016Status: Assigned (was: Untriaged)