New issue
Advanced search Search tips

Issue 607679 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 405845



Sign in to add a comment

DevTools: logged Object should always have expand arrow

Project Member Reported by paulir...@chromium.org, Apr 28 2016

Issue description

If we use the snapshot preview, we should still allow you to expand.

Screenshot of two almost identical objects.. the smaller without an expand arrrow

This bug from the Console improvements doc: https://docs.google.com/document/d/12qai4P6StUdxkn79E13kRTuBV-F8dWFPO774kiPouMc/edit#heading=h.t6w10swef9iv
 
Screen Shot 2016-04-28 at 1.47.23 PM.png
140 KB View Download
Blocking: 405845

Comment 2 by l...@chromium.org, May 9 2016

Status: Started (was: Assigned)
CL: https://codereview.chromium.org/1963753003/
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de

commit 9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de
Author: luoe <luoe@chromium.org>
Date: Thu May 19 01:11:40 2016

DevTools: default all console object previews to lossy

BUG= 607679 

Review-Url: https://codereview.chromium.org/1963753003
Cr-Commit-Position: refs/heads/master@{#394626}

[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-getProperties-preview-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/Source/devtools/protocol.json
[modify] https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Comment 4 by l...@chromium.org, May 19 2016

Status: Fixed (was: Started)

Sign in to add a comment