New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607676 link

Starred by 1 user
Status: Verified
Owner:
█ ajnolley@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Windows Host] Remove XP, Vista, and WS2K3 specific code for the Host

Project Member Reported by joedow@chromium.org, Apr 28 2016 
I've previously filed a bug for removal of the SAS Dll and supporting code, however I think there are a number of other one-off OS version checks in our code base that can be simplified now that the older OSes are not supported.  I would like to use this bug to track their removal and simplification of the code which relied on them.

Comment 1 by joedow@chromium.org, May 2 2016

Status: Assigned (was: Untriaged)

Comment 2 by joedow@chromium.org, Jun 3 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7da9460add084b17f47810cd4d4b755638a9c2e3

commit 7da9460add084b17f47810cd4d4b755638a9c2e3
Author: joedow <joedow@chromium.org>
Date: Tue Jun 07 00:18:04 2016

Removing WinXP and Vista specific code from Chromoting.

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG= 607676 

Review-Url: https://codereview.chromium.org/2037163002
Cr-Commit-Position: refs/heads/master@{#398169}

[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/clipboard_win.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/curtain_mode_win.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/setup/daemon_controller_delegate_win.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/setup/me2me_native_messaging_host_main.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/chromoting_module.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/com_security.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/com_security.h
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/launch_process_with_token.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/session_input_injector.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/unprivileged_process_delegate.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/worker_process_launcher.cc
[modify] https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3/remoting/host/win/wts_session_process_delegate.cc

Comment 4 by joedow@chromium.org, Jun 7 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
Crusty code removed, no user facing changes are expected here and also no regressions :)

Comment 5 by ajnolley@chromium.org, Jul 13 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment