Offline Pages: Website Settings Popup relies on synchronous APIs. |
|||
Issue descriptionAs part of the Offline Pages API project, we are making our model asynchronous. The Website Settings Popup uses the following deprecated APIs: OfflinePageBridge#getPageByOfflineUrl() Tab#isOfflinePage() Tab#getOfflinePageOriginalUrl() These will need to be updated to support the asynchronous offline model, possibly affecting the design of the UI class.
,
May 3 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1119715ee9e4d99a54002f891fccb92090880ae6 commit 1119715ee9e4d99a54002f891fccb92090880ae6 Author: chili <chili@chromium.org> Date: Wed May 18 18:08:14 2016 [OfflinePages] Make website settings popup rely on asynchronous API BUG= 607670 Review-Url: https://codereview.chromium.org/1969233002 Cr-Commit-Position: refs/heads/master@{#394469} [modify] https://crrev.com/1119715ee9e4d99a54002f891fccb92090880ae6/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java [modify] https://crrev.com/1119715ee9e4d99a54002f891fccb92090880ae6/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java [modify] https://crrev.com/1119715ee9e4d99a54002f891fccb92090880ae6/chrome/browser/android/offline_pages/offline_page_bridge.cc [modify] https://crrev.com/1119715ee9e4d99a54002f891fccb92090880ae6/chrome/browser/android/offline_pages/offline_page_bridge.h [modify] https://crrev.com/1119715ee9e4d99a54002f891fccb92090880ae6/components/offline_pages/offline_page_model.h
,
May 18 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fgor...@chromium.org
, Apr 29 2016Status: Assigned (was: Untriaged)