GN: chromeos: internal_khronos_glcts_tests set but not used |
||||
Issue descriptionError: The variable "internal_khronos_glcts_tests" was set as a build argument but never appeared in a declare_args() block in any buildfile. From issue 588080 : internal_khronos_glcts_tests is also not supported when building Chrome for Chrome OS with GN. This is because src/BUILD.gn depends on //gpu/khronos_glcts_support:khronos_glcts_test only when is_android || (is_linux && !is_chromeos).
,
Apr 28 2016
It is currently broken. You can disable it.
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f216067c67cff142cff41cac269ccf5628bce1b7 commit f216067c67cff142cff41cac269ccf5628bce1b7 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Apr 28 20:54:21 2016 GN: chromeos: Elim GN support for internal_khronos_glcts Currently internal_khronos_glcts is never referenced in chromium .gn files, so remove references to it in BUILD_ARGS until resolved. BUG= chromium:607669 TEST=USE="gn -build_tests" emerge-$BOARD chromeos-chrome: No build errors (Requires https://chromium-review.googlesource.com/#/c/341082/) Change-Id: Ic941f0e65c036f77dbc05fcfde65149963fbbce1 Reviewed-on: https://chromium-review.googlesource.com/341300 Reviewed-by: Ilja Friedel <ihf@chromium.org> Trybot-Ready: Ilja Friedel <ihf@chromium.org> Tested-by: Ilja Friedel <ihf@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/f216067c67cff142cff41cac269ccf5628bce1b7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Apr 29 2016
,
May 6 2016
This appears to also be related to internal_gles2_conform_tests, which depends on 'mustpass_es20.run'. I will try disabling those as well for now.
,
May 6 2016
We have too many dependencies, I'll file a separate issue.
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/604316365bf41a8ae4fd3ef4bff8ca5376f8a476 commit 604316365bf41a8ae4fd3ef4bff8ca5376f8a476 Author: stevenjb <stevenjb@chromium.org> Date: Fri May 06 22:10:26 2016 Add khronos_glcts_test to both_gn_and_gyp target This will allow us to re-enable internal_khronos_glcts_tests in chromeos-chrome-9999.ebuild if we need to. BUG= 607669 Review-Url: https://codereview.chromium.org/1954263002 Cr-Commit-Position: refs/heads/master@{#392173} [modify] https://crrev.com/604316365bf41a8ae4fd3ef4bff8ca5376f8a476/BUILD.gn
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Apr 28 2016