New issue
Advanced search Search tips

Issue 607663 link

Starred by 3 users
Status: Fixed
Owner:
fgor...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline Pages: port Custom Tabs menu bar UI to async.

Project Member Reported by dewittj@chromium.org, Apr 28 2016 
As part of the Offline Pages API project, we are making our model asynchronous.  The custom tabs menu bar (CustomTabToolbar.java) uses sync APIs provided by Tab.java and TabAndroid.

The following APIs are used:

Tab#isOfflinePage

This will need to be updated to support the asynchronous offline model.  Note that because navigation to an offline page will require the model being loaded, we may be able to ensure that the value is always cached in memory, so the APIs themselve may not need to be made async.

Comment 1 by fgor...@chromium.org, May 11 2016

Owner: fgor...@chromium.org
Status: Available (was: Untriaged)

Comment 2 by fgor...@chromium.org, Sep 2 2016

Status: Fixed (was: Available)
Custom tab menu bar was converted in 2 steps:
1. Offline page tab helper holds the offline page item
2. Offline page interceptor populate the offline page tab helper asynchronously

Custom tab menu bar uses the cached offline page item.
Original URL is the only relevant URL and no file:// substitution is necessary.
►

Sign in to add a comment