New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607630 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

URLRequestTestHTTP.UnsafeRedirectToDifferentUnsafeURL fails occasionally on iOS

Project Member Reported by rohitrao@chromium.org, Apr 28 2016

Issue description

On the iOS bots, this test occasionally fails with ERR_UNSAFE_PORT, which makes me think that the test http server might be getting a port that's disallowed.

We could try verifying this by EXPECT_TRUE(IsPortValid(port)).  Or we could try adding a ScopedPortException for the http server's port.


[ RUN      ] URLRequestTestHTTP.UnsafeRedirectToDifferentUnsafeURL
../../net/url_request/url_request_unittest.cc:6674: Failure
Value of: r->status().error()
  Actual: -312
Expected: ERR_UNSAFE_REDIRECT
Which is: -311
[  FAILED  ] URLRequestTestHTTP.UnsafeRedirectToDifferentUnsafeURL (2 ms)
 
This looks like it might be an issue with any test that uses EmbeddedTestServer?
Cc: marq@chromium.org
Labels: -Pri-3 Pri-2
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Owner: ----
Status: Untriaged (was: Assigned)
Setting to untriaged to let Networking team triage this better as I'm not familiar with URLRequest.
Cc: svaldez@chromium.org
+svaldez due to possibility of being EmbeddedTestServer related.
Owner: svaldez@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a501df838c21aa2087b0546dfa8ecce12b5fa08c

commit a501df838c21aa2087b0546dfa8ecce12b5fa08c
Author: rohitrao <rohitrao@chromium.org>
Date: Fri Dec 09 19:10:36 2016

Retry until EmbeddedTestServer is listening on a valid port.

The net stack will not send HTTP requests to a specific set of
blacklisted ports, but the OS may assign one of	those ports to
the EmbeddedTestServer.  This was causing spurious net_unittests
failures on iOS when it happened.  This CL modifies the
EmbeddedTestServer to retry until it is assigned a
non-blacklisted port.

BUG=607630

Review-Url: https://codereview.chromium.org/2562893002
Cr-Commit-Position: refs/heads/master@{#437602}

[modify] https://crrev.com/a501df838c21aa2087b0546dfa8ecce12b5fa08c/net/test/embedded_test_server/embedded_test_server.cc

svaldez: Are you still working on this?

Sign in to add a comment