New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607627 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 610780

Blocking:
issue 539572
issue 586704



Sign in to add a comment

libFuzzer ASan debug builds.

Project Member Reported by och...@chromium.org, Apr 28 2016

Issue description

We should experiment with fuzzing debug ASan libFuzzer builds, and add builders for them.
 
Cc: -mmoroz@chromium.org
Owner: mmoroz@chromium.org
Max, would you mind looking into this? Feel free to assign back to me if you're swamped with other things.
I don't mind to work on this, but probably cannot to do it very soon.

I think that we need:

1) build all fuzzers with debug and check which of them are not too noisy

2) then we probably will implement some simple white-listing and add a new configuration to build-bots

Both parts are easy, but first one may take some time since we have 80+ fuzzers.

I'll start to run locally debug builds of fuzzers in alphabetical order.
Hm, after some thinking I came to another point.

We may enable debug builds, but initially use empty while-list of fuzzers there.

Then, when somebody ensures that some fuzzer is silent enough to be fuzzed with debug build, we add it into the while-list.

So, I will start with adding new build configuration.
Sounds like a good way to get this started. Thanks, Max!
sgtm too. thanks!
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddbb47c14321d71cfc60d6a6684ae5db4b558ffc

commit ddbb47c14321d71cfc60d6a6684ae5db4b558ffc
Author: mmoroz <mmoroz@chromium.org>
Date: Tue May 10 17:16:35 2016

[libfuzzer] Adding ASan Debug build configuration.

R=aizatsky@chromium.org, dpranke@chromium.org, ochang@chromium.org
BUG= 607627 

Review-Url: https://codereview.chromium.org/1958133002
Cr-Commit-Position: refs/heads/master@{#392634}

[modify] https://crrev.com/ddbb47c14321d71cfc60d6a6684ae5db4b558ffc/tools/mb/mb_config.pyl

Comment 8 by mmoroz@chromium.org, May 10 2016

Blockedon: 610780
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87782

------------------------------------------------------------------
r87782 | recipe-roller@chromium.org | 2016-05-12T09:42:54.005718Z

-----------------------------------------------------------------
Hmm, looks like I missed something. Both CLs have been landed, master has been restarted, but I don't see Debug builds  https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1.
Great! Additional restart has been required (bug 610780).

Now we need to white-list fuzzers which are suitable for fuzzing with debug build. My suggestion is to use some additional environment variable for a new CF job (libfuzzer_chrome_asan_debug, isn't created yet). Something like DEBUG_FUZZERS_ENABLED=aaa_fuzzer:bbb_fuzzer:ccc_fuzzer. IMHO it would be easier to use than having a white-list in libfuzzer.py or anywhere else in the source code.
Blocking: 586704
Since I'm CF sheriff now and periodically checking CF reports, I dedicated bots 246-250 for libfuzzer_chrome_asan_debug job.

Recreated only one bot (246) at the moment to see how it goes.
Looks fine, I've recreated 4 more bots (247-250).
Cc: och...@chromium.org
Interesting, that debug builds are smaller than release ones, for example:

Release:
-rwxr-x--- 1 mmoroz eng 21014352 Aug 11 13:48 out/Release/icu_break_iterator_fuzzer

Debug:
-rwxr-x--- 1 mmoroz eng  2974824 Aug 11 13:59 out/Release/icu_break_iterator_fuzzer

Status: Fixed (was: Started)
Max, can you put this in sanitizer huge binary size bug. This bug for debug build support is done.

Sign in to add a comment