PDFium CQ commits when the PDFium tree is closed |
|||||||
Issue descriptionI hit the commit button in Rietveld when the tree was closed and my Cl was submitted. I was expecting it to wait to commit until the tree was open again.
,
May 2 2016
,
May 2 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/a86d113be692153d7707da377d11d4f09cb12c9b commit a86d113be692153d7707da377d11d4f09cb12c9b Author: dsinclair <dsinclair@chromium.org> Date: Mon May 02 14:42:03 2016 Add tree status check to PDFium CQ. This CL adds in the tree status check so the CQ will not commit if the waterfall closes the PDFium tree. BUG= chromium:607625 Review-Url: https://codereview.chromium.org/1937943002 [modify] https://crrev.com/a86d113be692153d7707da377d11d4f09cb12c9b/infra/config/cq.cfg
,
May 2 2016
Does the CQ need to be restarted to pickup this change or should it now be live?
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7b49810b22ebaed37a9290809dd6f21ae6bf453 commit a7b49810b22ebaed37a9290809dd6f21ae6bf453 Author: ochang <ochang@chromium.org> Date: Mon May 02 20:06:38 2016 Roll PDFium 76c5379..a86d113 https://pdfium.googlesource.com/pdfium.git/+log/76c5379..a86d113 BUG=62400,589955, 607625 , 596947 , 602505 , 607739 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/1938013002 Cr-Commit-Position: refs/heads/master@{#391037} [modify] https://crrev.com/a7b49810b22ebaed37a9290809dd6f21ae6bf453/DEPS
,
May 3 2016
See question in #4.
,
May 6 2016
The change should be live.
,
May 18 2016
,
Aug 22 2016
,
Aug 22 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by phajdan.jr@chromium.org
, Apr 29 2016