New issue
Advanced search Search tips

Issue 607625 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PDFium CQ commits when the PDFium tree is closed

Project Member Reported by dsinclair@chromium.org, Apr 28 2016

Issue description

I hit the commit button in Rietveld when the tree was closed and my Cl was submitted. I was expecting it to wait to commit until the tree was open again.
 
Components: -Infra>CQ Infra>Client>Pdfium
You need to configure cq.cfg (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/pdfium/infra/config/cq.cfg&q=cq.cfg%20pdfium&sq=package:chromium&l=5) to look for tree status, see e.g. https://code.google.com/p/chromium/codesearch#chromium/src/infra/config/cq.cfg&q=cq.cfg&sq=package:chromium&type=cs&l=1 :

  tree_status {
    tree_status_url: "https://chromium-status.appspot.com"
  }

(of course use pdfium tree status URL; you may need to set up one)
Owner: dsinclair@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/a86d113be692153d7707da377d11d4f09cb12c9b

commit a86d113be692153d7707da377d11d4f09cb12c9b
Author: dsinclair <dsinclair@chromium.org>
Date: Mon May 02 14:42:03 2016

Add tree status check to PDFium CQ.

This CL adds in the tree status check so the CQ will not commit if the waterfall
closes the PDFium tree.

BUG= chromium:607625 

Review-Url: https://codereview.chromium.org/1937943002

[modify] https://crrev.com/a86d113be692153d7707da377d11d4f09cb12c9b/infra/config/cq.cfg

Does the CQ need to be restarted to pickup this change or should it now be live?
Labels: Needs-Feedback
Owner: phajdan.jr@chromium.org
Status: Assigned (was: Started)
See question in #4.
Labels: -Needs-Feedback
Owner: dsinclair@chromium.org
The change should be live.
Status: Fixed (was: Assigned)
Components: Infra>Client
Components: -Infra>Client>Pdfium

Sign in to add a comment