New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Log urls and paths in BIDIRECTIONAL_STREAM events

Project Member Reported by xunji...@chromium.org, Apr 28 2016

Issue description

BIDIRECTIONAL_STREAM events do not have urls and paths in NetLog. This makes debugging hard. We should additionally log the headers sent and received in BIDIRECTIONAL_STREAM events. Headers are currently logged in HTTP2_SESSION and QUIC_SESSION. But the session events can have a bunch of requests going on, and it will be hard to associate headers sent and received with each bidirectional stream.
 
Status: Started (was: Assigned)
https://codereview.chromium.org/1932853002/
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4c21ab215ec191359bd8bb3f85f1249e219845c

commit d4c21ab215ec191359bd8bb3f85f1249e219845c
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Apr 28 22:44:47 2016

Log urls and headers in BIDIRECTIONAL_STREAM events

BIDIRECTIONAL_STREAM events do not have urls and headers in NetLog. This makes
debugging hard. Headers are currently logged in HTTP2_SESSION and QUIC_SESSION,
but the session events can have a bunch of requests going on, and it is hard to
associate headers with each bidirectional stream.

This CL logs urls and the headers sent and received in BIDIRECTIONAL_STREAM
events.

BUG= 607613 

Review-Url: https://codereview.chromium.org/1932853002
Cr-Commit-Position: refs/heads/master@{#390518}

[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/http/bidirectional_stream.cc
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/http/bidirectional_stream_unittest.cc
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/http/http_log_util.cc
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/http/http_log_util.h
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/log/net_log_event_type_list.h
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/d4c21ab215ec191359bd8bb3f85f1249e219845c/net/spdy/spdy_session.cc

Status: Fixed (was: Started)

Sign in to add a comment