New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607611 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a rule line between advanced and about chrome

Project Member Reported by bettes@chromium.org, Apr 28 2016

Issue description

rule-line: 1px #000, 0.14
padding: 8px 0 


SPEC
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-navigation.png%3Fz=width
 
Screen Shot 2016-04-28 at 10.25.23 AM.png
20.6 KB View Download
Status: Started (was: Assigned)
Edit: opacity: 0.08
So iiuc, this line on the grey background will be at 0.08
and the other lines (in the cards) on the white background
will be at 0.06 - is that right?
offline Alan says it's this way:
side nav separator line opacity 0.08;
all other lines 0.06
Project Member

Comment 5 by bugdroid1@chromium.org, May 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b838f3fc3fb41c43e69bc795394bad30a89b7f3

commit 1b838f3fc3fb41c43e69bc795394bad30a89b7f3
Author: dschuyler <dschuyler@chromium.org>
Date: Sat May 07 00:42:29 2016

[MD settings] separator line for side nav

This CL adds a grey line between the Advanced menu section and
the About Chrome in the side nav menu. (The bug has a screen shot
of line and spacing).

BUG= 607611 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1947923004
Cr-Commit-Position: refs/heads/master@{#392221}

[modify] https://crrev.com/1b838f3fc3fb41c43e69bc795394bad30a89b7f3/chrome/browser/resources/settings/settings_menu/settings_menu.html

Status: Fixed (was: Started)

Sign in to add a comment