DevTools: device art + fit to window is awkward |
||
Issue descriptiondevice art on on my macbook air Bottom of phone viewport is cut off our automatic viewport sizing doesnt get triggered even tho you can't see all. the inset math isn't being considered i guess. it should force scaling if bottom of phone viewport isn't in view but shouldn't if the fold happens after phone viewport and before bottom of device art. sorry for the quick bug report :)
,
Jun 15 2016
I'll second Pavel's choice that "Fit to Window" should include the device frame, particularly since the user has to opt in to that currently. Truncating the device frame strikes me as working against that choice. I wouldn't overthink the scaling issue. Bear in mind with most devices' pixel ratio, we're already scaling the displayed content (unless the majority of those 1440x900 screens are Retina). There are also screen sizes, not viewports-- add browser chrome and even a maximized window may require scaling. There's a third option for those that want device art AND no scaling: set the zoom to 100%. But we'll have to permit scrolling the outer container to support this without complete truncation.
,
Jun 15 2016
sg As of a few weeks back dgozman landed a change that meant the Fit To Window always includes the bounds of the art. So I think we can close this as fixed now. |
||
►
Sign in to add a comment |
||
Comment 1 by paulir...@chromium.org
, May 3 201618.8 KB
18.8 KB View Download