New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607595 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: device art + fit to window is awkward

Project Member Reported by paulir...@chromium.org, Apr 28 2016

Issue description

device art on
on my macbook air
Bottom of phone viewport is cut off
our automatic viewport sizing doesnt get triggered even tho you can't see all. 
the inset math isn't being considered i guess.

it should force scaling if bottom of phone viewport isn't in view
but shouldn't if the fold happens after phone viewport and before bottom of device art.

sorry for the quick bug report :)
 
Cc: chowse@chromium.org maxwalker@chromium.org
Talked with Pavel and he thinks that if you've got art on, then all the art should fit. While I hesitate about that, I see the point.

Pavel experimented with sliding the device up a bit (putting the art underneath the top toolbar (and turning on some opacity)). It was interesting, though I wasn't fond of it. He indicated we cannot make the visual workspace here scrollable, like it is in Framer. (due to device emulation viewport limitations)

So..

The leading solution is that Fit to Window fits the bounding box of the device art. This pretty much guarantees a scaled experience on many laptops. 

On my 13" MBA, all devices with art including the 5X should get scaled.
Attached are the common mac osx resolutions (google analytics from a popular site). Mine is the first (1440x900) which indicates that (probably) the typical mac user has a screen like mine. :/

I want our default experience to avoid scaling for the majority of our users, if possible. Hmmm

Ideas?
resolutions-mac osx - big site.png
18.8 KB View Download

Comment 2 by chowse@chromium.org, Jun 15 2016

I'll second Pavel's choice that "Fit to Window" should include the device frame, particularly since the user has to opt in to that currently. Truncating the device frame strikes me as working against that choice.

I wouldn't overthink the scaling issue. Bear in mind with most devices' pixel ratio, we're already scaling the displayed content (unless the majority of those 1440x900 screens are Retina). There are also screen sizes, not viewports-- add browser chrome and even a maximized window may require scaling.

There's a third option for those that want device art AND no scaling: set the zoom to 100%. But we'll have to permit scrolling the outer container to support this without complete truncation.

Owner: paulir...@chromium.org
Status: Fixed (was: Assigned)
sg

As of a few weeks back dgozman landed a change that meant the Fit To Window always includes the bounds of the art.
So I think we can close this as fixed now.

Sign in to add a comment