New issue
Advanced search Search tips

Issue 607592 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Add support to the installer for downgrading

Project Member Reported by grt@chromium.org, Apr 28 2016

Issue description

Summary says it
 

Comment 2 by zmin@chromium.org, May 4 2016

Test downgrade between 52.0.2724.0, 52.0.2723.3, 52.0.2723.2, everything looks good.

Comment 3 by zmin@chromium.org, May 4 2016

Next: Windows installer test(blocked: codereview.chromium.org/1929383002/), user data profiles.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18df9171296c5e7474adef49cd53d1638dbbb22c

commit 18df9171296c5e7474adef49cd53d1638dbbb22c
Author: zmin <zmin@chromium.org>
Date: Mon Jun 13 23:52:17 2016

Reset user data directory and disk cache directory after downgrade.

BUG=607592

Review-Url: https://codereview.chromium.org/1986823002
Cr-Commit-Position: refs/heads/master@{#399604}

[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/chrome_browser_main.cc
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/OWNER
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade.cc
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade.h
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade_browsertest.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser.h
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_linux.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_mac.mm
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_win.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/chrome_browser.gypi
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/chrome_tests.gypi
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util.h
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util_unittest.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/components/policy/resources/policy_templates.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18df9171296c5e7474adef49cd53d1638dbbb22c

commit 18df9171296c5e7474adef49cd53d1638dbbb22c
Author: zmin <zmin@chromium.org>
Date: Mon Jun 13 23:52:17 2016

Reset user data directory and disk cache directory after downgrade.

BUG=607592

Review-Url: https://codereview.chromium.org/1986823002
Cr-Commit-Position: refs/heads/master@{#399604}

[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/chrome_browser_main.cc
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/OWNER
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade.cc
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade.h
[add] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/downgrade/user_data_downgrade_browsertest.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser.h
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_linux.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_mac.mm
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/browser/policy/policy_path_parser_win.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/chrome_browser.gypi
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/chrome_tests.gypi
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util.h
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/chrome/installer/util/install_util_unittest.cc
[modify] https://crrev.com/18df9171296c5e7474adef49cd53d1638dbbb22c/components/policy/resources/policy_templates.json

Comment 8 by zmin@chromium.org, Jun 15 2016

Verify downgrade + user data cleanup by version 53.0.2768.0 and 53.0.2767.4.

Comment 9 by zmin@chromium.org, Jun 15 2016

Installer test for downgrade is still blocked by  crbug.com/605177 

Supports volume's root directory will be tracked by another issue(619133).
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c64a812b452a0bb8a890fe0e425a16283a02d1f

commit 5c64a812b452a0bb8a890fe0e425a16283a02d1f
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 13 15:59:21 2018

Allow downgrades via the command line.

Previously, downgrades were only possible via master_preferences (for
use by the enterprise wrapper). This change makes downgrades possible
via the command line.

BUG=607592
R=zmin@chromium.org

Change-Id: I5885fe9eb1b2f2ba477958a9d06797da6e9d4acc
Reviewed-on: https://chromium-review.googlesource.com/c/1333811
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607600}
[modify] https://crrev.com/5c64a812b452a0bb8a890fe0e425a16283a02d1f/chrome/installer/setup/install.cc
[modify] https://crrev.com/5c64a812b452a0bb8a890fe0e425a16283a02d1f/chrome/installer/util/master_preferences.cc
[modify] https://crrev.com/5c64a812b452a0bb8a890fe0e425a16283a02d1f/chrome/installer/util/util_constants.cc
[modify] https://crrev.com/5c64a812b452a0bb8a890fe0e425a16283a02d1f/chrome/installer/util/util_constants.h

Sign in to add a comment