MediaUrlResolver sends invalid range header
Reported by
ha...@zedge.net,
Apr 28 2016
|
||||||||
Issue descriptionThere is a hardcoded range header in MediaUrlResolver.java that does not conform to the range request specification. See: https://chromium.googlesource.com/chromium/src.git/+/master/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java#126 where a range header is hardcoded to the string "bytes: 0-65536" According to RFC 7233, the correct syntax would be "bytes=0-65536", fetching the first 65537 bytes of the file. The current header will most likely fail to parse and be ignored. This bug has been around for a while, but for whatever reason Chrome 50 seems to send a lot more of these requests than previous versions.
,
May 3 2016
,
May 3 2016
avayvod@ has taken over ownership of Cast.
,
May 3 2016
Thanks for the correction and filing a bug! Too late to fix in M50 I'm afraid, but I'll try to merge it to M51.
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aac6bc58659266a161c5eb3aa011c12f1a6da4f3 commit aac6bc58659266a161c5eb3aa011c12f1a6da4f3 Author: avayvod <avayvod@chromium.org> Date: Tue May 03 14:34:32 2016 [Android,MediaFling] Fix the range request value in MediaUrlResolver. BUG= 607552 TEST=automated + manual tests Review-Url: https://codereview.chromium.org/1943273002 Cr-Commit-Position: refs/heads/master@{#391228} [modify] https://crrev.com/aac6bc58659266a161c5eb3aa011c12f1a6da4f3/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java [modify] https://crrev.com/aac6bc58659266a161c5eb3aa011c12f1a6da4f3/chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
,
May 3 2016
,
May 3 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97e081796c88c9d5ed432c47817b98381a2fd158 commit 97e081796c88c9d5ed432c47817b98381a2fd158 Author: Anton Vayvod <avayvod@google.com> Date: Tue May 03 14:51:47 2016 [Android,MediaFling] Fix the range request value in MediaUrlResolver. BUG= 607552 TEST=automated + manual tests Review-Url: https://codereview.chromium.org/1943273002 Cr-Commit-Position: refs/heads/master@{#391228} (cherry picked from commit aac6bc58659266a161c5eb3aa011c12f1a6da4f3) Review URL: https://codereview.chromium.org/1944753002 . Cr-Commit-Position: refs/branch-heads/2704@{#353} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/97e081796c88c9d5ed432c47817b98381a2fd158/chrome/android/java/src/org/chromium/chrome/browser/media/remote/MediaUrlResolver.java [modify] https://crrev.com/97e081796c88c9d5ed432c47817b98381a2fd158/chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
,
May 3 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ppolise...@chromium.org
, May 2 2016Components: Blink>Media
Owner: qin...@chromium.org
Status: Assigned (was: Unconfirmed)