Issue 607550 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	csharrison@chromium.org
Closed:	Jun 2016
Cc:	█ bmcquade@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

page_load_metrics system sometimes does not track pages that commit then abort

Project Member Reported by csharrison@chromium.org, Apr 28 2016

Issue description

We start the metrics IPC timer when a metric has updated (i.e. first paint). However, for precise abandonment metrics, we should send up an IPC on commit time so the browser knows the renderer is tracking this page load.

As of now, if a page is aborted right after commit (and fast shutdown occurs), we lose the information and assume the renderer was uninterested in this page load.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f699127554b22fed13c910611ca8ce429041509e

commit f699127554b22fed13c910611ca8ce429041509e
Author: csharrison <csharrison@chromium.org>
Date: Thu Apr 28 14:22:24 2016

[page_load_metrics] Eagerly send IPCs on navigation commit

This starts the page_load_metrics IPC timer a bit earlier, so we know to start tracking a committed load in the browser process.

BUG= 607550 

Review-Url: https://codereview.chromium.org/1918393002
Cr-Commit-Position: refs/heads/master@{#390372}

[modify] https://crrev.com/f699127554b22fed13c910611ca8ce429041509e/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
[modify] https://crrev.com/f699127554b22fed13c910611ca8ce429041509e/components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc
[modify] https://crrev.com/f699127554b22fed13c910611ca8ce429041509e/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
[modify] https://crrev.com/f699127554b22fed13c910611ca8ce429041509e/components/page_load_metrics/renderer/page_timing_metrics_sender.h
[modify] https://crrev.com/f699127554b22fed13c910611ca8ce429041509e/components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc

Comment 2 by csharrison@chromium.org, Jun 21 2016

Status: Fixed (was: Started)

This is probably the best we can do here. I'll open another bug if I notice anything else we could be doing.

►

Issue 607550 link

Issue metadata

page_load_metrics system sometimes does not track pages that commit then abort

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 28 2016

Comment 1 Deleted

Comment 2 by csharrison@chromium.org, Jun 21 2016

Comment 2 Deleted

Sign in to add a comment