New issue
Advanced search Search tips

Issue 607540 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Web Platform Text Encoder textdecoder-fatal-single-byte.html Failure

Project Member Reported by dtapu...@chromium.org, Apr 28 2016

Issue description

In change https://codereview.chromium.org/1924663004/
third_party/WebKit/LayoutTests/imported/web-platform-tests/encoding/textdecoder-fatal-single-byte.html was imported.

The test has a number of failures in the
textdecoder-fatal-single-byte-expected.txt

 
Summary: Web Platform Text Encoder textdecoder-fatal-single-byte.html (was: Web Platform Text Encoder test failing)
Summary: Web Platform Text Encoder textdecoder-fatal-single-byte.html Failure (was: Web Platform Text Encoder textdecoder-fatal-single-byte.html)

Comment 3 by jsb...@chromium.org, Apr 28 2016

Cc: js...@chromium.org
Example: 

new TextDecoder('iso-8859-3', {fatal:true}).decode(new Uint8Array([190]))

Expected: throws
Actual: Produces U+FFFD

In contrast, this throws correctly:

new TextDecoder('utf-16', {fatal:true}).decode(new Uint8Array([0]))
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34757324c45fe5f1d61338c9458f0fa556a2f3a9

commit 34757324c45fe5f1d61338c9458f0fa556a2f3a9
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Apr 28 20:03:06 2016

Import web-platform-tests@12528872c91a3996dce9053e5f8bcf2dddc54ec5

Using update-w3c-deps in Blink 1d491ec4d5956c60fbf72e8cb5d3b27c842f9e6b.

Add expected tests for the tests that with reproducible failures instead
of skipping them.

BUG= 606875 ,  606900 ,  606934 ,  607540 

Review-Url: https://codereview.chromium.org/1924663004
Cr-Commit-Position: refs/heads/master@{#390453}

[modify] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/README.md
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/encoding/textdecoder-fatal-single-byte.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-1.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-2-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-with-cross-frame-event-listeners-2.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Document-prototype-adoptNode.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Document-prototype-importNode.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/shadow-dom/Node-prototype-cloneNode.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/easing-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/easing.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/fill-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/fill.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/discrete-animation-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/discrete-animation.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/not-animatable-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-model/animation-types/not-animatable.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/finished-expected.txt
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/finished.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/oncancel.html
[add] https://crrev.com/34757324c45fe5f1d61338c9458f0fa556a2f3a9/third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation/onfinish.html

Status: Started (was: Assigned)
CL up at https://codereview.chromium.org/2235453002/
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/005842b420cace28845fc552ef6da8086fe527a5

commit 005842b420cace28845fc552ef6da8086fe527a5
Author: jsbell <jsbell@chromium.org>
Date: Tue Aug 16 05:11:11 2016

Text Encoding: Fix "stop on error" for ICU-based codecs

Handling of errors when the "stopOnError" flag was set in
TextCodecICU::decode() was incorrect; the replacement character was
always emitted instead. Align the initialization of the ICU error
callback with what i18n/icu_string_conversions.cc does.

BUG= 607540 
R=jshin@chromium.org

Review-Url: https://codereview.chromium.org/2235453002
Cr-Commit-Position: refs/heads/master@{#412170}

[delete] https://crrev.com/75fced2336ef1b15095f9e111b411b3ef860960c/third_party/WebKit/LayoutTests/imported/wpt/encoding/textdecoder-fatal-single-byte-expected.txt
[modify] https://crrev.com/005842b420cace28845fc552ef6da8086fe527a5/third_party/WebKit/Source/wtf/text/TextCodecICU.cpp

Comment 7 by jsb...@chromium.org, Aug 16 2016

Status: Fixed (was: Started)

Sign in to add a comment