New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607532 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Debugger UI doesn't update when debugging code with source maps

Reported by willdema...@gmail.com, Apr 28 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.29 Safari/537.36

Steps to reproduce the problem:
1. Generate any code with a transform and a sourcemap (e.g. ES2015 through Babel)
2. Set a breakpoint on any line of code which will be executed
3. Refresh the page
4. Attempt to step-in or step-over the line of code

What is the expected behavior?
The debugger UI should update to reflect the current execution pointer.

What went wrong?
The debugger UI only partially updates. The current line is not highlighted jumped-to. Other elements, such as the stack trace, update correctly. A video of this behaviour is attached.

Did this work before? Yes 50.0.2661.86

Chrome version: 51.0.2704.29  Channel: beta
OS Version: 
Flash Version: Shockwave Flash 21.0 r0
 
Screencast from 04-28-2016 01:27:13 PM.webm
837 KB Download

Comment 1 by allada@chromium.org, Apr 28 2016

Owner: kozyatinskiy@chromium.org
Labels: Needs-Feedback
Status: Assigned (was: Unconfirmed)
Could you please provide output of console for DevTools?
To open DevTools for DevTools please follow next steps:
1. Click "Undock into separate window" in "Dock side" item in DevTools Menu near the DevTools close button.
2. Click Ctrl+Shift+I when focus in DevTools window.
3. Open Console and copy errors.
I think that it should be presented there.
I have same problem on windows10.

[windows10: 51.0.2704.79 m]
{Async} is checked.

Sorry it's difficult to create minimal test case...

------------
(anonymous function) @ VM534:1
inspector.js:1499 TypeError: Cannot read property 'sourceURL' of null TypeError: Cannot read property 'sourceURL' of null
    at Object.WebInspector.CallStackSidebarPane.CallFrame (sources_module.js:formatted:436)
    at Object._callFramesFromRuntime (sources_module.js:formatted:223)
    at Object.update (sources_module.js:formatted:187)
    at Object._showDebuggerPausedDetails (sources_module.js:formatted:6316)
    at Object._debuggerPaused (sources_module.js:formatted:6309)
    at Object.dispatchEventToListeners (inspector.js:765)
    at Object._setDebuggerPausedDetails (inspector.js:5598)
    at Object._pausedScript (inspector.js:5602)
    at Object.paused (inspector.js:5659)
    at Object.dispatch (inspector.js:4254)innerDispatch @ inspector.js:1499_dispatch @ inspector.js:1498_dispatchOnInspectorFrontendAPI @ VM42:61dispatchMessage @ VM42:146(anonymous function) @ VM724:1
> location
W…r.D…l.Location {_target: W…r.Target, _debuggerModel: W…r.DebuggerModel, scriptId: "631", lineNumber: 625, columnNumber: 31}_debuggerModel: WebInspector.DebuggerModel_target: WebInspector.TargetcolumnNumber: 31lineNumber: 625scriptId: "631"__proto__: ObjectcontinueToLocation: ()id: ()payload: ()script: ()__proto__: Object
> location.script()
null <-- location.script() returns null.
----
WebInspector.CallStackSidebarPane.CallFrame = function(functionName, location, linkifier, debuggerCallFrame, locationPool, asyncCallFrame) {
    WebInspector.UIList.Item.call(this, WebInspector.beautifyFunctionName(functionName), "");
    this._location = location;
    this._debuggerCallFrame = debuggerCallFrame;
    this._asyncCallFrame = asyncCallFrame;
    if (asyncCallFrame) {
        var locationElement = linkifier.linkifyRawLocation(location, location.script().sourceURL); <-- here
        this.subtitleElement.appendChild(locationElement);
    } else {
        this._liveLocationPool = new WebInspector.LiveLocationPool();
        WebInspector.debuggerWorkspaceBinding.createCallFrameLiveLocation(location, this._update.bind(this), locationPool);
    }
}

I have the same problem, even without sourcemaps
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72a48adc8a6f4cd97fe77a3536e707df53847a1

commit c72a48adc8a6f4cd97fe77a3536e707df53847a1
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Jul 30 02:18:14 2016

[DevTools] Fix location.script().sourceURL

Script can be null.

BUG= 607532 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2198443004
Cr-Commit-Position: refs/heads/master@{#408843}

[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
[modify] https://crrev.com/c72a48adc8a6f4cd97fe77a3536e707df53847a1/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

Status: Fixed (was: Assigned)

Sign in to add a comment