New issue
Advanced search Search tips

Issue 607519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug

Blocking:
issue 707186



Sign in to add a comment

Use @IntDef in java_cpp_enum

Project Member Reported by bauerb@chromium.org, Apr 28 2016

Issue description

See https://goto.google.com/xbujrb: We should create @IntDef annotations for Java enum values generated by java_cpp_enum.
 

Comment 1 by peconn@chromium.org, Apr 28 2016

Owner: peconn@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/1932183002#
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5

commit 2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5
Author: peconn <peconn@chromium.org>
Date: Mon Aug 01 15:56:19 2016

Add IntDefs to generated Java enums.

BUG= 607519 
TBR=agrieve@chromium.org

Review-Url: https://codereview.chromium.org/1932183002
Cr-Commit-Position: refs/heads/master@{#408973}

[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/android_webview/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/base/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/blimp/client/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/build/android/gyp/java_cpp_enum.py
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/build/android/gyp/java_cpp_enum_tests.py
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/components/bookmarks/common/android/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/components/cronet/android/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/components/sync/android/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/device/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/device/gamepad/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/media/capture/video/android/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/net/android/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/ui/accessibility/BUILD.gn
[modify] https://crrev.com/2e675b536d1e1ed1cf50610fae5ec4960d6cb7a5/ui/android/BUILD.gn

Labels: zine-16-08-01
Status: Fixed (was: Started)

Comment 6 by dgn@chromium.org, Mar 31 2017

Blocking: 707186

Sign in to add a comment