New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Dump or show the raw snippet data from ChromeReader via chrome://snippets-internals

Project Member Reported by maybelle@chromium.org, Apr 28 2016

Issue description

Would like to be able to get a raw dump of the data we get from ChromeReader. It would be useful to debug whether an issue is with us or with the data. The current dump offered is only after we've already processed it.
 

Comment 1 by bauerb@chromium.org, Apr 28 2016

Cc: jkrcal@chromium.org

Comment 2 by jkrcal@chromium.org, Apr 28 2016

Cc: -jkrcal@chromium.org
Owner: jkrcal@chromium.org
No problem.

Comment 3 by jkrcal@chromium.org, Apr 28 2016

Status: Started (was: Untriaged)

Comment 4 by jkrcal@chromium.org, Apr 28 2016

Labels: zine-mr-iter-13
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e

commit eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e
Author: jkrcal <jkrcal@chromium.org>
Date: Mon May 02 09:14:00 2016

Allow dumping raw json fetched from the server.

On top of dumping the whole list of snippets, this adds the feature to
dump the json of the newly fetched snippets.

Furthermore, the CL fixes a minor bug discovered while testing the CL: the list of snippets was truncated to max_length before deleting outdated snippets - sometimes resulting in less snippets.

BUG= 607518 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1927993002
Cr-Commit-Position: refs/heads/master@{#390905}

[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/chrome/browser/resources/snippets_internals.css
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/chrome/browser/resources/snippets_internals.html
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/chrome/browser/resources/snippets_internals.js
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/chrome/browser/ui/webui/snippets_internals_message_handler.h
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/components/ntp_snippets/ntp_snippets_service.cc
[modify] https://crrev.com/eb20b3cc1cd1c5b9eeb1e780764c9120f2c7d48e/components/ntp_snippets/ntp_snippets_service.h

Status: Fixed (was: Started)
After some fetching is performed, a "Last JSON" section appears on the internals page where you can see or download it.

Sign in to add a comment