Regression: Invalidation for entered number in 'Sensors' section is not shown in dev tools.
Reported by
rk...@etouch.net,
Apr 28 2016
|
|||
Issue descriptionChrome version : 52.0.2719.0 db7757b63f29696b9b465949f9704a0d9d149f2b-refs/heads/master@{#390251} 32/64 bit OS : Windows (7, 8, 10), Mac 10.10.5, Linux What steps will reproduce the problem? 1. Launch chrome and open dev tools window. 2. Press Esc key,navigate to Sensors section and click on 'Accelerometer' drop down list. 3. Select 'Custom Orientation', click in text box and enter invalid number, observe. Invalidation doesnot shown for invalid numbers in sensors text box. Invalidation should be show for invalid numbers in sensors text box. This is a regression issue, broken in 'M-52', below is bisect info: Good Build : 52.0.2718.0 Bad Build : 52.0.2719.0 Narrow Bisect info: https://chromium.googlesource.com/chromium/src/+log/7e7d3daff9117163ca29f1614a9e45ee1cb47b23..c80c8d6b64756dbd6b3a34cbf2f7f5e6473eed0c?pretty=fuller&n=100 Suspecting : r390131
,
May 3 2016
Issue is still reproducible on Windows 7 using chrome latest canary M52-52.0.2723.0. Observed that invalidation does not show for the invalid numbers in sensors text box. luoe@ - Any update on this bug? Could you please look in to this issue. Thanks!
,
May 3 2016
@brajkumar, yes, there is a CL in review right now, which should re-introduce validation for those fields. https://codereview.chromium.org/1923393006/ Hopefully it will land today or very soon.
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fd06ffec9d7e331e754d77bfd8e11e780b17f70 commit 6fd06ffec9d7e331e754d77bfd8e11e780b17f70 Author: luoe <luoe@chromium.org> Date: Wed May 04 19:59:05 2016 DevTools: fix styles and input validation in sensor pane BUG= 607491 , 607511 Review-Url: https://codereview.chromium.org/1923393006 Cr-Commit-Position: refs/heads/master@{#391603} [modify] https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70/third_party/WebKit/Source/devtools/front_end/emulation/DeviceOrientation.js [modify] https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70/third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js [modify] https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js [modify] https://crrev.com/6fd06ffec9d7e331e754d77bfd8e11e780b17f70/third_party/WebKit/Source/devtools/front_end/emulation/sensors.css
,
May 4 2016
Changes committed. Please review if needed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkonch...@chromium.org
, Apr 28 2016