New issue
Advanced search Search tips

Issue 607501 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Apr 2016
Cc:
sabineb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Save password prompt appears twice

Project Member Reported by vasi...@chromium.org, Apr 28 2016 
Version: 51
OS: all

If a site integrates the Credential Manager API the it's recommended to call 'store' for the autofill login. At the same time the conventional password manager kicks in. If user quickly dismisses the first save prompt then he might see it again.

Comment 2 by vasi...@chromium.org, Apr 29 2016

Labels: Merge-Request-51
I want to merge r390384 back. The implementation is simple and safe.

Comment 3 by tin...@google.com, Apr 29 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9663d49b8305d2b348cee20e8ec8bb007223601e

commit 9663d49b8305d2b348cee20e8ec8bb007223601e
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Apr 29 14:55:55 2016

Suppress the autofill password manager after a credential was saved via the API.

Without this the user may see two save prompts one after another.

BUG= 607501 

Review-Url: https://codereview.chromium.org/1929953002
Cr-Commit-Position: refs/heads/master@{#390384}
(cherry picked from commit 86f6265c50793ff42c9853640610c20ba5eadbf6)

Review URL: https://codereview.chromium.org/1934603002 .

Cr-Commit-Position: refs/branch-heads/2704@{#309}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/9663d49b8305d2b348cee20e8ec8bb007223601e/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/9663d49b8305d2b348cee20e8ec8bb007223601e/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/9663d49b8305d2b348cee20e8ec8bb007223601e/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/9663d49b8305d2b348cee20e8ec8bb007223601e/chrome/browser/password_manager/password_manager_test_base.h

Comment 5 by vasi...@chromium.org, Apr 29 2016

Status: Fixed (was: Started)

Comment 6 by ssamanoori@chromium.org, May 4 2016

Labels: Needs-Feedback
vasilii@Could you please provide reproducible steps to verify the fix from test team end.

Comment 7 by vasi...@chromium.org, May 4 2016 

It was reproduced by on a real third party site. I'll ask if they have a public version online.

Comment 8 by vasi...@chromium.org, May 4 2016

Labels: -Needs-Feedback
Follow the steps from  http://crbug.com/603427
►

Sign in to add a comment