New issue
Advanced search Search tips

Issue 607500 link

Starred by 1 user
Status: Fixed
Owner:
timloh@chromium.org
Closed: Jul 2016
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

@import trying to load file named "url" for badstring

Reported by r...@opera.com, Apr 28 2016 
The test below will try to load a file called "url".

<!DOCTYPE html>
<style>
    @import url("fail.css
);
</style>
<div id="fail"></div>
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f

commit 76a6f7c50105f7e7b1335aee6ab73297e6e85b6f
Author: timloh <timloh@chromium.org>
Date: Fri Jul 01 03:00:52 2016

Fix assertion when parsing @namespace/@import with url(<bad-string-token>)

This patch fixes incorrect handling of <bad-string-token> inside
@namespace/@import rules. Currently a url(<bad-string-token>) is
incorrectly interpreted as url(url).

The added tests pass in Firefox.

BUG= 607095 , 607500 

Review-Url: https://codereview.chromium.org/1930823002
Cr-Commit-Position: refs/heads/master@{#403396}

[add] https://crrev.com/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f/third_party/WebKit/LayoutTests/fast/css/import-with-bad-string.html
[add] https://crrev.com/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f/third_party/WebKit/LayoutTests/fast/css/namespaces/invalid-url-in-namespace.html
[modify] https://crrev.com/76a6f7c50105f7e7b1335aee6ab73297e6e85b6f/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp

Comment 2 by timloh@chromium.org, Jul 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment