Regression: Unable to scroll the apps section of google maps on closing devtools window.
Reported by
lpa...@etouch.net,
Apr 28 2016
|
||||||||||
Issue descriptionChrome Version: 52.0.2719.0 (Official Build) db7757b63f29696b9b465949f9704a0d9d149f2b-refs/heads/master@{#390251} 32/64 Bit. OS: Windows (10, 8, 8.1, 7), Mac (10.10.5)(10.11.4), Linux (ubuntu 14.04 LTS) Steps: 1. Launch chrome and navigate to https://www.google.co.in/maps?hl=en 2. Press Ctrl+Shift+I to open dev tools, dock it to right. 3. Toggle to device mode, click on 'Apps' icon and close the devtools window. 4. Try to scroll the 'Apps' section. Actual: Unable to scroll the apps section. Expected: Should be able to scroll the apps section. This is a regression issue broken in M-51. Manual Regression Range: Good Build: 51.0.2686.0 Bad Build: 51.0.2687.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/9231ba274a1c6525bf06cfc1a214fae2967663b7..9776192405fc5584424bf597db98f22b5b955594?pretty=fuller&n=100 Suspect: r382353
,
Apr 28 2016
Looks like this is probably a device mode regression.
,
May 3 2016
Able to reproduce the issue on mac 10.11 chrome version 52.0.2723.0 dgozman@, Could you please take a look
,
May 9 2016
just to update,still able to reproduce the issue on windows 7 using chrome version 52.0.2729.0 .
,
May 9 2016
A friendly reminder that M51 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by May 17. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thanks!
,
May 9 2016
This is definitely https://codereview.chromium.org/1776843003. Not sure that's a bug though - maps surely don't expect touch to appear and then disappear and could break in unpredictable ways. Over to Dave to assess whether the problem exists.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a5f4dbe106611593f05ba7ae163d1660f219f6a commit 3a5f4dbe106611593f05ba7ae163d1660f219f6a Author: dtapuska <dtapuska@chromium.org> Date: Thu May 12 20:53:49 2016 Touch Action could cause wheel gestures to be filtered. If the source device is not touchscreen the touch action filter should not do anything. A certain drop list in Google maps was failing to scroll via wheel scrolling because it had installed a touch action none filter. BUG= 607495 Review-Url: https://codereview.chromium.org/1971273002 Cr-Commit-Position: refs/heads/master@{#393348} [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/browser/renderer_host/input/touch_action_filter.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/browser/renderer_host/input/touch_action_filter_unittest.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/browser/web_contents/web_contents_view_aura_browsertest.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/common/input/synthetic_web_input_event_builders.cc [modify] https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a/content/common/input/synthetic_web_input_event_builders.h
,
May 16 2016
Tested this issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest canary M52-52.0.2737.0 and observed the issue is not reproducible. Now it's able to scroll the apps section of google maps on closing dev tools window as expected. Hence adding TE-Verified label.
,
May 16 2016
,
May 16 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/984f294b46d7fbc882a14d7a8352b88c3c4f8e39 commit 984f294b46d7fbc882a14d7a8352b88c3c4f8e39 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon May 16 12:39:06 2016 Touch Action could cause wheel gestures to be filtered. If the source device is not touchscreen the touch action filter should not do anything. A certain drop list in Google maps was failing to scroll via wheel scrolling because it had installed a touch action none filter. BUG= 607495 Review-Url: https://codereview.chromium.org/1971273002 Cr-Commit-Position: refs/heads/master@{#393348} (cherry picked from commit 3a5f4dbe106611593f05ba7ae163d1660f219f6a) Review URL: https://codereview.chromium.org/1981843003 . Cr-Commit-Position: refs/branch-heads/2704@{#553} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/browser/renderer_host/input/touch_action_filter.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/browser/renderer_host/input/touch_action_filter_unittest.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/browser/web_contents/web_contents_view_aura_browsertest.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/common/input/synthetic_web_input_event_builders.cc [modify] https://crrev.com/984f294b46d7fbc882a14d7a8352b88c3c4f8e39/content/common/input/synthetic_web_input_event_builders.h
,
May 16 2016
M50 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thank you!
,
May 16 2016
,
May 18 2016
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 51.0.2704.54.Observed that able to scroll the apps section after closing the dev tools window in device mode. Please find attached screencast. Marking it as TE-Verified.
,
Jun 21 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tkonch...@chromium.org
, Apr 28 2016