New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607472 link

Starred by 0 users
Status: Duplicate
Merged: issue 607467
Owner:
█ brettw@chromium.org
Last visit 26 days ago
Closed: May 2016
Cc:
agrieve@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug

Blocking:
issue 359249
issue 607463



Sign in to add a comment

gn passes additional -m flags to build

Project Member Reported by jochen@chromium.org, Apr 28 2016 
gn passes the following flags that gyp doesn't define:

      -g
      -momit-leaf-frame-pointer
      -mstack-alignment=16
      -mstackrealign

Comment 1 by machenb...@chromium.org, Apr 28 2016 

For the last two we had a patch recently (stand-alone):
https://chromium.googlesource.com/v8/v8/+/3afb3324941625559635380ef98a2ee73e370a0a

is32 only, but that should be the same in chromium, no? At least chromium's common.gypi has the same three lines.

Comment 2 by machenb...@chromium.org, Apr 28 2016 

If this is arm only then disregard my comment.

Comment 3 by jochen@chromium.org, Apr 28 2016 

hum, well, arm compiles ia32 on the host, so maybe it's related?

Comment 4 by dpranke@chromium.org, Apr 28 2016

Blocking: 359249
Components: Build
Labels: Proj-GN-Migration
Did you mean for this to be P0? The other bugs you filed were P1. I don't care which priority you set, but was wondering whether this was more important or not ...

Comment 5 by dpranke@chromium.org, Apr 28 2016 

never mind, I guess they're all P0 ...

Comment 6 by jochen@chromium.org, Apr 28 2016 

uh, yeah, everything is P0... M51 is kinda soonish

Comment 7 by jochen@chromium.org, May 2 2016

Mergedinto: 607467
Status: Duplicate (was: Assigned)
►

Sign in to add a comment