gyp sets -fomit-frame-pointer but gn does not |
|||
Issue descriptionI guess it should also be set by gn. For gyp, the flag is not controlled by v8, so I guess it should be set everywhere?
,
Apr 28 2016
I've put my config on www/~eisinger/gn/
,
Apr 28 2016
,
Apr 29 2016
I believe Jochen was looking at the flags for the host build of the V8 snapshot generator when he filed this. GYP sets OS=="android" for both host and target compiles. For the few targets compiled in both, they have to carefully write target_conditions to tweak the files and flags as appropriate. In GN, the different toolchains are independent. Android sets omit-frame-pointer and Linux doesn't. So in GYP this is inherited in the host build even though that was never the intent.
,
May 2 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Apr 28 2016Cc: agrieve@chromium.org
Labels: Proj-GN-Migration