New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607461 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug

Blocked on:
issue 607463



Sign in to add a comment

Android gn configuration differs significantly from gyp

Project Member Reported by jochen@chromium.org, Apr 28 2016

Issue description

meta bug to collect all the issues
 

Comment 1 by jochen@chromium.org, Apr 28 2016

Blockedon: 607463
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b20a0b0c441cd686e8273550e2d5da149db811

commit 52b20a0b0c441cd686e8273550e2d5da149db811
Author: jochen <jochen@chromium.org>
Date: Fri Apr 29 20:16:34 2016

Set ARM/MIPS configuration for both host and target if needed

Also, the config should check whether the target is android, not whether
the current toolchain is android

BUG= 607461 
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/1934713002
Cr-Commit-Position: refs/heads/master@{#390735}

[modify] https://crrev.com/52b20a0b0c441cd686e8273550e2d5da149db811/build/config/arm.gni
[modify] https://crrev.com/52b20a0b0c441cd686e8273550e2d5da149db811/build/config/mips.gni

Cc: dpranke@chromium.org jochen@chromium.org
 Issue 607463  has been merged into this issue.
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f580f76503286c56742a9148455e50d3d41390c6

commit f580f76503286c56742a9148455e50d3d41390c6
Author: jochen <jochen@chromium.org>
Date: Mon May 02 08:10:32 2016

Port arm, arm64, mipsle, and mips64le flags to GN

BUG= chromium:607461 
R=machenbach@chromium.org,brettw@chromium.org
LOG=n

Review-Url: https://codereview.chromium.org/1927893002
Cr-Commit-Position: refs/heads/master@{#35922}

[modify] https://crrev.com/f580f76503286c56742a9148455e50d3d41390c6/BUILD.gn

Summary: Android gn configuration differs significantly from gyp (was: [meta] Android gn configuration differs significantly from gyp)
Status: Fixed (was: Assigned)
I manually verified that the flags now all match for mipsel, arm, and arm64
Labels: Merge-Request-51
mlamouri@ was so kind to verify a ToT build.

Comment 9 by tin...@google.com, May 3 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ff2d81d48334142d8a04a466c52cae5c37195a

commit 35ff2d81d48334142d8a04a466c52cae5c37195a
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue May 03 08:45:26 2016

Set ARM/MIPS configuration for both host and target if needed

Also, the config should check whether the target is android, not whether
the current toolchain is android

BUG= 607461 
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/1934713002
Cr-Commit-Position: refs/heads/master@{#390735}
(cherry picked from commit 52b20a0b0c441cd686e8273550e2d5da149db811)

Review URL: https://codereview.chromium.org/1946473003 .

Cr-Commit-Position: refs/branch-heads/2704@{#348}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/35ff2d81d48334142d8a04a466c52cae5c37195a/build/config/arm.gni
[modify] https://crrev.com/35ff2d81d48334142d8a04a466c52cae5c37195a/build/config/mips.gni

Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2016

Labels: merge-merged-5.1
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5598f91a5ebdf60faf08cedda461447cfdcbb406

commit 5598f91a5ebdf60faf08cedda461447cfdcbb406
Author: Jochen Eisinger <jochen@chromium.org>
Date: Tue May 03 09:00:17 2016

Version 5.1.281.27 (cherry-pick)

Merged f580f76503286c56742a9148455e50d3d41390c6

Port arm, arm64, mipsle, and mips64le flags to GN

BUG= chromium:607461 
LOG=N
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/1940213002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#31}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}

[modify] https://crrev.com/5598f91a5ebdf60faf08cedda461447cfdcbb406/BUILD.gn
[modify] https://crrev.com/5598f91a5ebdf60faf08cedda461447cfdcbb406/include/v8-version.h

Sign in to add a comment