New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Hook up storage purging mechanisms to base::MemoryPressureListener

Project Member Reported by dk...@chromium.org, Apr 28 2016

Issue description

As per thread here:
https://groups.google.com/a/chromium.org/forum/?nomobile=true#!topic/project-trim/akay4BZVxeU

The current logic to purge storage memory use is more or less hardcoded to execute when the number of open areas is >100. We should tune this heuristic for different platforms and also make it use MemoryPressureListener

 

Comment 1 by dk...@chromium.org, May 16 2016

Owner: michaeln@chromium.org
@Michael, could you take a look at this with the rest of the mojo-ification work you're looking at? It would be nice to get this fixed in the next quarter or two if possible!
Owner: ssid@chromium.org
this is about to land in the context of the existing impl https://codereview.chromium.org/1953703004/

Comment 3 by jsb...@chromium.org, May 17 2016

Blockedon: 612525
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454f3cefe1b33de5a422778e5cf09d6311bb7fa7

commit 454f3cefe1b33de5a422778e5cf09d6311bb7fa7
Author: ssid <ssid@chromium.org>
Date: Mon May 23 21:33:48 2016

Purge browser cache for dom storage in a smarter way

This CL does:
1. Use the total cache size to decide when to purge memory from in
   memory caches.
2. Use different limits on databases and cache sizes based on the
   platform and the ram available.
3. For low memory devices do not keep any cache around for closed
   databases (closed tabs).
4. Add a memory pressure listener to dom storage. This listener is
   supposed to construct and destruct in same thread. So, it is
   constructed and destructed on UI thread by DOMStorageContextWrapper
   and post tasks purge to the dom task runner.

BUG= 610551 , 607449 

Review-Url: https://codereview.chromium.org/1953703004
Cr-Commit-Position: refs/heads/master@{#395418}

[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_area.h
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_context_impl.h
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_context_impl_unittest.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_database.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_host.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_namespace.cc
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/browser/dom_storage/dom_storage_namespace.h
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/content/common/dom_storage/dom_storage_types.h
[modify] https://crrev.com/454f3cefe1b33de5a422778e5cf09d6311bb7fa7/tools/metrics/histograms/histograms.xml

Comment 5 by ssid@chromium.org, Jun 20 2016

Status: Fixed (was: Available)
Some optimizations are left, tracked by  bug 610551 .

Comment 6 by jsb...@chromium.org, Jun 20 2016

Blockedon: -612525

Sign in to add a comment