New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607444 link

Starred by 1 user
Status: WontFix
Owner:
tapted@chromium.org
Closed: May 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Spacing issue is observed on Blocked plugins bubble in ‘youtube .com’

Reported by dmascare...@etouch.net, Apr 28 2016 
Chrome Version:52.0.2719.0 db7757b63f29696b9b465949f9704a0d9d149f2b-refs/heads/master@{#390251} 32/64 bit
OS: Mac (10.10.5)(10.11.4)

Pre-condition:
1. Enable Toolkit-Views Browser Dialogs flag.
2. Select ‘Let me choose when to run plugin content’ on chrome://settings/content page

What steps will reproduce the problem?
1. Launch chrome and navigate to https://www.youtube.com/
2. Click on blocked plugin icon present in omnibox and observe the space between first line and ‘Learn more link.

Actual: Spacing issue is observed on Blocked plugins bubble.
Expected: Spacing issue should not be seen.

This is regression issue, broken in ‘M 50’ and below is ChangeLog:
https://chromium.googlesource.com/chromium/src/+log/50.0.2646.0..50.0.2647.0?pretty=fuller&n=10000

Suspecting: r374756 ?

Good build:50.0.2646.0
Bad build:50.0.2647.0

Kindly help to re-assign, if your changes are not cause for this issue.

Note: Above flags is not available for Windows and Linux OS.
real.png
160 KB View Download

Comment 1 by est...@chromium.org, Apr 28 2016

Owner: tapted@chromium.org
I don't think that it can be my change because I touched a different bubble in that CL (the one that is shown here is content_setting_bubble_contents.cc).

It looks like a lot of spacing and font and appearance changes occurred between expected and actual. I assume this is a normal consequence of macviews work.

Comment 2 by tapted@chromium.org, May 4 2016

Status: WontFix (was: Assigned)
I think this is fine. You see similar changes in the spacing here simply by changing your language (or possibly just by navigating to a site with a long hostname that surfaces this dialog). The "Learn more" link isn't attached to the text, but attached to the top-right layout cell of the dialog.

In this case, font sizes changed, so the layout differs. We still need to tweak those for specific dialogs, but it's not a bug yet.
►

Sign in to add a comment