New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607439 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: Yes
Launch-M-Approved: ----
Launch-M-Target: 53-Stable
Launch-Privacy: NA
Launch-Security: NotReviewed
Launch-Test: Yes
Launch-UI: NA
Rollout-Type: ----

Blocked on:
issue 543997



Sign in to add a comment

Unprefix navigator.getUserMedia

Project Member Reported by hta@chromium.org, Apr 28 2016

Issue description

Currently we have the navigator.webkitGetUserMedia. According to specs, it should be navigator.getUserMedia.

This bug exists to keep track of that unprefixing.

It's presumed to depend on getting constraints up to par with specs.

 
Cc: jansson@chromium.org
Status: Available (was: Untriaged)

Comment 2 by hta@chromium.org, Jun 10 2016

Owner: hta@chromium.org
Status: Started (was: Available)

Comment 3 by hta@chromium.org, Jun 10 2016

Labels: -Type-Bug Type-Launch-OWP

Comment 4 by hta@chromium.org, Jun 10 2016

Cc: blum@chromium.org

Comment 5 by blum@chromium.org, Jun 10 2016

Labels: M-53 Launch-Accessibility-NA Launch-Legal-NotReviewed Launch-Privacy-NotReviewed Launch-Security-NotReviewed Launch-Status-Approval-Requested Launch-Test-NotReviewed Launch-UI-NA

Comment 6 by blum@chromium.org, Jun 10 2016

Labels: -Launch-Status-Approval-Requested Launch-Status-Review-Requested
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489f502a4d2d39665eb58158dc5df313ee2dbf15

commit 489f502a4d2d39665eb58158dc5df313ee2dbf15
Author: hta <hta@chromium.org>
Date: Fri Jun 10 11:45:04 2016

Make ready to unprefix getUserMedia, and counters

This CL adds an unprefixed getUserMedia on navigator,
behind the same flag as the promise-based getUserMedia.
It also counts all three variants.

BUG= 607439 

Review-Url: https://codereview.chromium.org/2045193003
Cr-Commit-Position: refs/heads/master@{#399156}

[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-expected.txt
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia.html
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.h
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.idl
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/tools/metrics/histograms/histograms.xml

Note that the spec says to use navigator.mediaDevices.getUserMedia, and that navigator.getUserMedia is considered legacy.

E.g. Firefox unprefixed the former a while ago (in 44, along with RTCPeerConnection) but not navigator.mozGetUserMedia, and we're not planning to, instead we show a deprecation warning on use.

We did that to drive convergence around navigator.mediaDevices.getUserMedia. That said, I know Edge implemented navigator.getUserMedia.
Also it is trivially polyfilled:

    navigator.getUserMedia = (c, y, n) => { navigator.mediaDevices.getUserMedia(c).then(y, n); }
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489f502a4d2d39665eb58158dc5df313ee2dbf15

commit 489f502a4d2d39665eb58158dc5df313ee2dbf15
Author: hta <hta@chromium.org>
Date: Fri Jun 10 11:45:04 2016

Make ready to unprefix getUserMedia, and counters

This CL adds an unprefixed getUserMedia on navigator,
behind the same flag as the promise-based getUserMedia.
It also counts all three variants.

BUG= 607439 

Review-Url: https://codereview.chromium.org/2045193003
Cr-Commit-Position: refs/heads/master@{#399156}

[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-expected.txt
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia.html
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.cpp
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.h
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.idl
[modify] https://crrev.com/489f502a4d2d39665eb58158dc5df313ee2dbf15/tools/metrics/histograms/histograms.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d229d009b74255797c16bef6b7e398a165dbeacd

commit d229d009b74255797c16bef6b7e398a165dbeacd
Author: hta <hta@chromium.org>
Date: Wed Jun 15 16:33:15 2016

Turn on standard GetUserMedia versions by default.

This includes navigator.getUserMedia (no prefix) and
navigator.mediaDevices.getUserMedia (promise-returning).

Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/E4LA0P0YYPQ/4LGTKRcDBwAJ

BUG= 607439 

Review-Url: https://codereview.chromium.org/2070453003
Cr-Commit-Position: refs/heads/master@{#399921}

[modify] https://crrev.com/d229d009b74255797c16bef6b7e398a165dbeacd/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d229d009b74255797c16bef6b7e398a165dbeacd/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 12 by hta@chromium.org, Jun 16 2016

Labels: OWP-Standards-OfficialSpec

Comment 13 by ctanaka@google.com, Jun 16 2016

Labels: -Launch-Legal-NotReviewed Launch-Legal-Yes
hta@ does this mean navigator.webkitGetUserMedia() will cease to exist?
adapter.js issue filed https://github.com/webrtc/adapter/issues/335 for checking if it needs to be updated for this.
Labels: -Launch-Test-NotReviewed Launch-Test-Yes

Comment 17 by hta@chromium.org, Jun 21 2016

Labels: -Launch-Test-Yes Launch-Test-NotReviewed
Specific tests:

Layout test getusermedia-promise.html tests the promise-based version.
Layout test getusermedia.html tests that the callback-based version work.

All are in third_party/WebKit/LayoutTests/fast/mediastream

Comment 19 by hta@chromium.org, Jun 23 2016

Blockedon: 622613
Privacy review 622613.
Chrome Privacy don't normally review OWP launches. Is there anything specific you'd like us to know?

Comment 21 by hta@chromium.org, Jun 28 2016

I don't think this really needs a privacy review, but I was not sure of the process, given that the launch flag exists on the template.

If OWP bugs don't need privacy review in general, please change this status to "Launch-Privacy: Yes" (there is no "NA) and close the review bug. Thanks!

Labels: PrivacyReview-622613
Will this make it to M53?

Comment 24 by hta@chromium.org, Jul 19 2016

Blockedon: -622613
Labels: -Launch-Privacy-NotReviewed Launch-Privacy-NA
Closing privacy review bug and setting to Privacy-Review-NA. Seems not required.

Comment 25 by blum@chromium.org, Jul 19 2016

Labels: Launch-M-Approved-53-Stable
re. #23: yes, this is the plan. Can you do a test review, please?

Comment 26 by blum@chromium.org, Jul 19 2016

Labels: -Launch-M-Approved-53-Stable Launch-M-Target-53-Stable
Labels: -Launch-Test-NotReviewed Launch-Test-Yes
hta@, does this also serve as the tracking bug for unprefixing MediaStream? I couldn't find a separate issue for that, and I'd like a tracking bug for https://docs.google.com/spreadsheets/d/1Fqv1JyadCDGMJ91GdIYPQicI97ELIHabwUfxFQv-jLU/edit#gid=0 :)
Since this is marked as 53-stable, can this be marked as Fixed?

Comment 30 by hta@chromium.org, Nov 23 2016

Status: Fixed (was: Started)
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c2ab69a068a6c9b589086b7c9d1331a166dc1e

commit f9c2ab69a068a6c9b589086b7c9d1331a166dc1e
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon Sep 18 21:04:38 2017

navigator.getUserMedia: Retire runtime flag

navigator.getUserMedia shipped in M53.

The runtime flag GetUserMedia is no longer needed.

BUG= 607439 

Change-Id: I6f7eb1b5e60651f8298cb13a57b9481ef60af535
Reviewed-on: https://chromium-review.googlesource.com/668261
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502677}
[modify] https://crrev.com/f9c2ab69a068a6c9b589086b7c9d1331a166dc1e/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl
[modify] https://crrev.com/f9c2ab69a068a6c9b589086b7c9d1331a166dc1e/third_party/WebKit/Source/modules/mediastream/NavigatorMediaStream.idl
[modify] https://crrev.com/f9c2ab69a068a6c9b589086b7c9d1331a166dc1e/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031ae98ad9bacc976feb9bd844aa74a9f0a117a6

commit 031ae98ad9bacc976feb9bd844aa74a9f0a117a6
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Wed Oct 24 14:52:32 2018

[getUserMedia, ImageCapture] Cleanup a TODO to remove GetUserMedia flag.

The runtime flag GetUserMedia is no longer needed as
navigator.getUserMedia shipped in M53

BUG= 607439 

Change-Id: Id58babefdb6611e27021d0b2b1af2119d785bf8a
Reviewed-on: https://chromium-review.googlesource.com/c/1296594
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#602336}
[modify] https://crrev.com/031ae98ad9bacc976feb9bd844aa74a9f0a117a6/content/browser/webrtc/webrtc_image_capture_browsertest.cc

Sign in to add a comment