New issue
Advanced search Search tips

Issue 607438 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Checkboxes are clipped by border-radius

Reported by trsta...@gmail.com, Apr 28 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36

Steps to reproduce the problem:
1. the issue occurs within our web app which utilizes jquery - see attached screen shots.  We also included a web inspector screen shot.
2. contact us and we can provide you with a temporary user id and password to the application if need be (email us at support@quikkast.com)
3. 

What is the expected behavior?
element should display as a checkbox, now displays as a radio button

What went wrong?
see attached screen shots from previous version of Chrome and latest version of Chrome.  You will see that the checkboxes appear correctly in the older version of chrome and look like radio buttons in the newest version of Chrome 

Did this work before? Yes all releases prior to version 50.0.2661.86

Chrome version: 50.0.2661.86  Channel: stable
OS Version: OS X 10.9.5
Flash Version: Shockwave Flash 21.0 r0
 
Screen Shot 2016-04-28 at 3.32.42 AM.png
33.5 KB View Download
Screen Shot 2016-04-28 at 3.35.32 AM.png
38.2 KB View Download
Screen Shot 2016-04-28 at 3.53.16 AM.png
530 KB View Download

Comment 1 by trsta...@gmail.com, Apr 28 2016

Upon further investigation, it appears the checkboxes are now inheriting the rounded corners of the object containing the buttons.

Comment 2 by trsta...@gmail.com, Apr 28 2016

We have isolated the issue to the following line of js code which for some reason Chrome is now applying these styles to checkboxes, where previously the styles were only applied in text fields.  It appears that Chrome has changed how classes are added to an input field of type select.

$('input, select').addClass('ui-corner-all ui-widget ui-state-default custom-combobox-input');
Components: -UI Blink>Forms>Checkbox
Labels: Needs-Reduction
Hi, is it possible for you to provide a minimal working example that reproduces this?  Have you tried this on Windows or Linux?

Comment 4 by trsta...@gmail.com, Apr 29 2016

Hi,

We have created two minimal working examples for you.  One example shows
the checkbox broken and the other shows the checkbox fixed.  We have
annotated the code with comments to explain why it broke within our code
using the latest release of Chrome, and what we did to work around the
problem.

Please use the following two web links to see the code in action.

quikkast.com/chrome-test/broken.php

quikkast.com/chrome-test/fixed.php

If you inspect the source code you will see our comments.  Also, commenting
out the ajax/googleapis.com... library corrects the problem as well.
However we need that library in our code.

We have also include a zip file of the complete set of code.

Hope this helps you solve the problem, as we had to rework a lot of code
quickly.

Tim

Comment 5 by tkent@chromium.org, May 2 2016

Components: Blink>Paint
Labels: -Needs-Reduction -Type-Bug Type-Bug-Regression
Owner: schenney@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Checkboxes are clipped by border-radius (was: jquery checkboxes displaying as radio buttons)
-webkit-appearance rendering is clipped by border-radius.  This is a regression, but IMO we may close this as WontFix.


Bisect result:

You are probably looking for a change made after 376535 (known good), but no later than 376543 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f9e06bc4b2845a0b67c7b86497c2ea0be24cc616..46a5c2196e3746c376c1bdf75a8339732cd373b0


Status: Available (was: Assigned)
The bisect is probably correct in attributing it to my change for background-image bleed avoidance. We are now apparently clipping the control, which only shows up on Mac presumably because we are using the system theme controls. Looking very closely there are some stray anti-aliased pixels around the corners of the clipped buttons.

It seems an error to me that we were not previously applying the border radius. Maybe that can be set on the Mac checkbox drawing so that it does not get clipped.

Comment 7 by tkent@chromium.org, May 6 2016

Cc: tkent@chromium.org
Components: -Blink>Forms>Checkbox
Project Member

Comment 8 by sheriffbot@chromium.org, May 8 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
The testcases provided in comment 4 are no longer available.
Labels: -Hotlist-Recharge-Cold PaintTeamTriaged-20170508 BugSource-User
Status: WontFix (was: Assigned)
We are applying the border radius as we are told to, whereas we were erroneously not previously. We'll leave it as it is now.

Sign in to add a comment