New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607426 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Browser gets crashed on opening chrome://devices in guest mode.

Project Member Reported by bj00129...@techmahindra.com, Apr 28 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2719.0 Safari/537.36

Steps to reproduce the problem:
1. Browse as guest
2. Open Chrome://devices and observe

What is the expected behavior?
Browser should not crash on navigating to chrome://devices in guest mode.

What went wrong?
Instead browser crashes.

Crashed report ID: 087543d200000000,

How much crashed? Whole browser

Is it a problem with a plugin? N/A 

Did this work before? Yes 

Chrome version: 52.0.2719.0  Channel: dev
OS Version: 52.0.2719.0
Flash Version: Shockwave Flash 21.0 r0

This is a regression issue broken in M52.
 
Cc: kavvaru@chromium.org ajha@chromium.org durga.behera@chromium.org
Labels: -Type-Bug -Pri-2 -Via-Wizard Needs-Bisect hasTestcase M-52 OS-Windows Pri-1 Type-Bug-Regression
Issue is also seen in windows.

Comment 2 by ajha@chromium.org, Apr 28 2016

Labels: ReleaseBlock-Stable
Status: Untriaged (was: Unconfirmed)
Issue is reproducible on the latest canary(52.0.2719.0) on Mac OS 10.11.3 as well.

Jahnavi@: Please update the bisect here.

Thank you!

Comment 3 by ajha@chromium.org, Apr 28 2016

Labels: -Needs-Bisect hasbisect OS-Mac
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Last good build: 52.0.2714.0
First bad build: 52.0.2715.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/52.0.2714.0..52.0.2715.0?pretty=fuller&n=10000

Based on the code search on 'local_discovery_ui_handler.cc' suspecting: https://codereview.chromium.org/1898503002 from the above range.

thestig@: Could you please take a look at this.

Thank you!
Attaching videos for reference.
Actual_crash.ogv
1.5 MB Download
Expected_crash.ogv
786 KB Download

Comment 5 Deleted

Project Member

Comment 6 by sheriffbot@chromium.org, Apr 28 2016

Labels: Fracas
Users experienced this crash on the following builds:

Mac Canary 52.0.2719.0 -  0.46 CPM, 1 reports, 1 clients (signature base::internal::WeakReferenceOwner::GetRef)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Status: Started (was: Assigned)
https://codereview.chromium.org/1928013003
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ded7edaf64916e44fe6f16f025b9f86a178df1

commit 53ded7edaf64916e44fe6f16f025b9f86a178df1
Author: thestig <thestig@chromium.org>
Date: Fri Apr 29 18:07:44 2016

Fix a crash in LocalDiscoveryUIHandler.

GetCloudPrintProxyService() can return NULL in guest mode.

BUG= 607426 

Review-Url: https://codereview.chromium.org/1928013003
Cr-Commit-Position: refs/heads/master@{#390697}

[modify] https://crrev.com/53ded7edaf64916e44fe6f16f025b9f86a178df1/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Status: Fixed (was: Started)
Cc: sshruthi@chromium.org gov...@chromium.org
Labels: M-51
This is the top#1 browser crash on latest Chrome beta i.e, 51.0.2704.47 :
https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3Ainternal%3A%3AWeakReferenceOwner%3A%3AGetRef%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#samplereports:5,productversion:1000
 

Want to check if we need the Cl from Comment#8 to get merged to M51, thestig@ if we have to merge can you please get the merge before 4pm today please. 
Sorry, but this is not a top crash. If you look at the actual stack traces in the comment 10 link, they are for other bugs.
Labels: -M-51
In fact, M51 branched at r386251, and this regressed afterwards in r388954.

Sign in to add a comment