New issue
Advanced search Search tips

Issue 607425 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

IME APIs don't work on beta/stable channels

Project Member Reported by shuchen@chromium.org, Apr 28 2016

Issue description

Version: R51
OS: Windows/Linux

What steps will reproduce the problem?
(1) Make a mini extension with "input" permission.
(2) Verify the chrome.input.ime.xxx APIs.

Actual:
chrome.input is undefined.

 
Labels: -M-51 M-53
Postpone to M53.
Status: WontFix (was: Started)
Using the launch bug 517773 to track.
Status: Started (was: WontFix)
Reopen this issue for M53 merge.

Summary: IME APIs don't work on beta/stable channels (was: IME APIs don't work on M51 beta)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f9aaee9da59138d3bde342bff4d18011694ef5f

commit 3f9aaee9da59138d3bde342bff4d18011694ef5f
Author: shuchen <shuchen@chromium.org>
Date: Thu Aug 25 05:24:46 2016

Makes the IME APIs available for beta/stable channels.

BUG= 607425 ,517773

Review-Url: https://codereview.chromium.org/1925983002
Cr-Commit-Position: refs/heads/master@{#414313}

[modify] https://crrev.com/3f9aaee9da59138d3bde342bff4d18011694ef5f/chrome/common/extensions/api/_permission_features.json

Labels: Merge-Request-53
Requesting merge to M53 as the launch crbug.com/517773 has been approved for M53.

Comment 8 by gov...@chromium.org, Aug 25 2016

Before we approve merge to M53, Could you please confirm whether this change is well baked/verified in Canary/dev and safe to merge? Please note that we're very close to M53 stable promotion and bar is very high. We can take this change only if it is important and safe.

Looks like testing was performed on launch bug by test team: https://bugs.chromium.org/p/chromium/issues/detail?id=517773#c106 
Yes, the feature is well tested by QA team.

The APIs have been available in Canary/Dev channels since M52, and we've dogfood it for quite a while.

The cl https://codereview.chromium.org/1925983002 is to enable the APIs to beta/stable channels so I think the cl is safe and won't cause regressions in other parts of chromium.

Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #9. Please merge ASAP. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 25 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/962fcf0020d880c7923a67792df0dae634664543

commit 962fcf0020d880c7923a67792df0dae634664543
Author: Shu Chen <shuchen@google.com>
Date: Thu Aug 25 07:56:08 2016

Makes the IME APIs available for beta/stable channels.

BUG= 607425 ,517773

Review-Url: https://codereview.chromium.org/1925983002
Cr-Commit-Position: refs/heads/master@{#414313}
(cherry picked from commit 3f9aaee9da59138d3bde342bff4d18011694ef5f)

Review URL: https://codereview.chromium.org/2276303002 .

Cr-Commit-Position: refs/branch-heads/2785@{#748}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/962fcf0020d880c7923a67792df0dae634664543/chrome/common/extensions/api/_permission_features.json

Status: Fixed (was: Started)

Sign in to add a comment