New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
inactive
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Weird white patch is seen after dragging app in chrome://apps

Reported by vku...@etouch.net, Apr 28 2016

Issue description

Chrome Version:52.0.2719.0 (Official Build) Revision db7757b63f29696b9b465949f9704a0d9d149f2b-refs/heads/master@{#390251}(32/64-bit)
OS:Mac (10.10.5)(10.11.4)

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://apps
2.Zoom in the page to 200% , drag any app at bottom near 'remove from chrome' and observe the apps page.

Actual: Weird white patch is seen after dragging app in chrome://apps

Expected: White patch should not be seen all apps should be visible after dragging app.

This is a regression issue broken in 'M51' and will soon update other info.
 

Comment 1 by vku...@etouch.net, Apr 28 2016

Labels: hasbisect OS-Linux OS-Windows
Owner: davve@opera.com
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 51.0.2688.0
Bad Build:  51.0.2689.0

Narrow bisect
https://chromium.googlesource.com/chromium/src/+log/3174947e46175db49b0fae95863c79cac5f6ba4e..43dee10eb95216504d473681287d186569e443e0?pretty=fuller&n=30

Suspecting: 382842 ?
Kindly help to re-assign, if your changes are not cause for this issue.

Note: Issue is seen on Windows (7, 8, 10) & Linux (ubuntu 14.04 LTS)

Actual_Apps.mov
1.1 MB Download
Expected_Apps.mov
1.2 MB Download

Comment 2 by vku...@etouch.net, Apr 28 2016

Cc: tkonch...@chromium.org
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.

Comment 4 by davve@opera.com, May 2 2016

Cc: f...@opera.com
Components: Blink>CSS
Gradient stops (used by a -webkit-mask-box-image in chrome://apps) scales its individual stops according to effecting zoom, making it incompatible with the way SVG is implemented (uses scaling on paint from unzoomed to zoomed coordinate systems). So fixing the latter (as in r382842) broke the former causing this bug.

A revert of r382842 and a re-think is probably the best course of action.
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6529aa5b970ab274de1ff4c0475f223930babff7

commit 6529aa5b970ab274de1ff4c0475f223930babff7
Author: davve <davve@opera.com>
Date: Mon May 02 11:57:49 2016

Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset
#3.

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG= 607414 , 596075, 561519

Review-Url: https://codereview.chromium.org/1934953002
Cr-Commit-Position: refs/heads/master@{#390920}

[modify] https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/5bed693d2607cf9bb51183909bc2f01be934a610/third_party/WebKit/LayoutTests/svg/css/border-image-zoomed-expected.html
[delete] https://crrev.com/5bed693d2607cf9bb51183909bc2f01be934a610/third_party/WebKit/LayoutTests/svg/css/border-image-zoomed.html
[modify] https://crrev.com/6529aa5b970ab274de1ff4c0475f223930babff7/third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp

Comment 7 by davve@opera.com, May 3 2016

Labels: Merge-Request-51

Comment 8 by tin...@google.com, May 3 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c436224c8f8c681c6b441f130c3839784d746c

commit 96c436224c8f8c681c6b441f130c3839784d746c
Author: David Vest <davve@opera.com>
Date: Tue May 03 13:04:44 2016

Revert "Straighten out zoom and border-image"

This patch reverts https://codereview.chromium.org/1819083004 patchset

Fixing SVG zoom in border-image unfortunatly broke gradients
instead. There is a difference in how scale it applied for
zooming. For SVG a source rect (unzoomed) <-> destination rect
(zoomed) scale factor is computed and used for scaling. For gradients,
the source and destination rect are always the same (both zoomed). The
individual gradients stops are zoomed instead.

BUG= 607414 , 596075, 561519

Review-Url: https://codereview.chromium.org/1934953002
Cr-Commit-Position: refs/heads/master@{#390920}
(cherry picked from commit 6529aa5b970ab274de1ff4c0475f223930babff7)

Review URL: https://codereview.chromium.org/1946543002 .

Cr-Commit-Position: refs/branch-heads/2704@{#351}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/96c436224c8f8c681c6b441f130c3839784d746c/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/third_party/WebKit/LayoutTests/svg/css/border-image-zoomed-expected.html
[delete] https://crrev.com/a8de7f8d6820d42bf0a476fd3029dd0cf0ae9c36/third_party/WebKit/LayoutTests/svg/css/border-image-zoomed.html
[modify] https://crrev.com/96c436224c8f8c681c6b441f130c3839784d746c/third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp

Comment 10 by davve@opera.com, May 4 2016

Status: Fixed (was: Assigned)
Cc: rnimmagadda@chromium.org
Labels: TE-Verified-51.0.2704.36 TE-Verified-M51
Verified the fix on Windows 7, MAC (10.11.4) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 51.0.2704.36

Screen-recording is attached.

TE-Verified Labels are added.
607414.mov
5.5 MB Download

Sign in to add a comment