New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"text-combine-upright:all" is rendered incorrectly in ruby.

Reported by babata...@gmail.com, Apr 28 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.87 Safari/537.36

Example URL:

Steps to reproduce the problem:
Open attached HTML.

What is the expected behavior?
"平成" should be rendered in 1em box (as if it is outside of ruby).

What went wrong?
"平成" is not compressed to 1em square, then it overlaps with the <rt>.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 52.0.2718.0  Channel: canary
OS Version: 6.3
Flash Version: Shockwave Flash 21.0 r0
 
testcase.html
454 bytes View Download
chrome52.png
1.9 KB View Download
Components: Blink>Fonts
Cc: kavvaru@chromium.org
Labels: -Type-Compat hasbisect M-52 OS-Linux OS-Mac Type-Bug-Regression
Owner: kojii@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7,Linux Ubuntu 14.04 and Mac 10.11.4 using chrome version 50.0.2661.94 and canary 52.0.2719.0.
This is regression issue broken in M42.Please find the bisect information as below

Narrow Bisect::
Good::42.0.2295.0  --  (official build 314531)
Bad::42.0.2296.0  --  (official build 314783)

CHANGELOG URL:  
https://chromium.googlesource.com/chromium/src/+log/8787ad84e79b909f951bdca491ab1ef48a7ead3c..82feb714b91b89685aacbbc8f49f6dc4145b0a4b

Blink CL::
https://chromium.googlesource.com/chromium/blink/+log/600d716..4b9569f

Possible suspect from the above Blink CL
https://chromium.googlesource.com/chromium/blink/+/898d5e85468ec16bcfb8a23af1617c0ca6189581

kojii@ Could you please look into this issue if it is related to your change,else please route this to an appropriate dev person.

Thanks,
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211db48591bc2bb3ff91d250c263606f1e3ae333

commit 211db48591bc2bb3ff91d250c263606f1e3ae333
Author: kojii <kojii@chromium.org>
Date: Wed Aug 17 03:03:50 2016

Fix when there are justification opportunities inside text-combine-upright

This patch fixes justification spacing to not to apply inside a
text-combine-upright when it has justification opportunities.

The spec[1] defines that "For...spacing, the resulting composition is
treated as a single glyph".

[1] https://drafts.csswg.org/css-writing-modes-3/#text-combine-layout

BUG= 607404 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2248803002
Cr-Commit-Position: refs/heads/master@{#412437}

[add] https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333/third_party/WebKit/LayoutTests/fast/writing-mode/text-combine-justify-expected.html
[add] https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333/third_party/WebKit/LayoutTests/fast/writing-mode/text-combine-justify.html
[modify] https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/211db48591bc2bb3ff91d250c263606f1e3ae333/third_party/WebKit/Source/platform/text/TextRun.h

Comment 6 by kojii@chromium.org, Aug 17 2016

Labels: -OS-Linux -OS-Windows -OS-Mac OS-All
Status: Fixed (was: Assigned)
Still the ruby-specific justification, space-around, doesn't look really as expected, but at least no longer overlaps.

Sign in to add a comment