Three other tests are failing on the current master-

MenuRunnerTest.WidgetDoesntTakeCapture (../../ui/views/controls/menu/menu_runner_unittest.cc:220)

WidgetTest.CaptureDuringMousePressNotOverridden (../../ui/views/widget/widget_unittest.cc:1821)

WidgetTest.MousePressCausesCapture (../../ui/views/widget/widget_unittest.cc:1758)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd1c18785711cd69951fac3dfd6964d08d296d66

commit dd1c18785711cd69951fac3dfd6964d08d296d66
Author: karandeepb <karandeepb@chromium.org>
Date: Mon May 30 01:20:56 2016

MacViews:Fix failing Menu Runner Cocoa Tests.

This CL fixes the following failing tests-
  -MenuRunnerCocoaTest.RunMenuAndCancel
  -MenuRunnerCocoaTest.RunMenuTwice

These tests regressed in crrev.com/1876013002. This CL fixes these tests by
changing MenuCancelCallback() to expect MenuRunner::IsRunning() to be true,
immediately after the call to MenuRunner::Cancel(). This is correct since
MenuRunner::Cancel() only marks the nested message loop for termination. Since
we are in the last iteration of the nested message loop, MenuRunner::IsRunning()
should still return true.

An interactive test is also added to test this behavior for MenuRunnerImpl.

BUG= 607403 

Review-Url: https://codereview.chromium.org/1951223002
Cr-Commit-Position: refs/heads/master@{#396664}

[modify] https://crrev.com/dd1c18785711cd69951fac3dfd6964d08d296d66/chrome/browser/ui/views/menu_controller_interactive_uitest.cc
[modify] https://crrev.com/dd1c18785711cd69951fac3dfd6964d08d296d66/chrome/browser/ui/views/menu_test_base.h
[modify] https://crrev.com/dd1c18785711cd69951fac3dfd6964d08d296d66/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

migrating Phase2 stuff to M53

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f03b5ff77766b46bbec2c564f3cee40fbe5968

commit 60f03b5ff77766b46bbec2c564f3cee40fbe5968
Author: karandeepb <karandeepb@chromium.org>
Date: Thu Jun 02 06:42:14 2016

MacViews: Fix failing NativeWidgetMacTest.ChangeOpacity test.

NativeWidgetMacTest.ChangeOpacity test regressed in crrev.com/2009333002. The
reason for the failure is that the expectation for [ns_window alphaValue] is a
double value, while Widget::SetOpacity(..) takes a float value. Changing the
expectation to a float literal fixes the test.

BUG= 607403 

Review-Url: https://codereview.chromium.org/2027143002
Cr-Commit-Position: refs/heads/master@{#397318}

[modify] https://crrev.com/60f03b5ff77766b46bbec2c564f3cee40fbe5968/ui/views/widget/native_widget_mac_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce26dc83bff3f79f27b698f9cddeb7d9470949a

commit 1ce26dc83bff3f79f27b698f9cddeb7d9470949a
Author: tapted <tapted@chromium.org>
Date: Mon Jun 27 03:13:03 2016

Add views_unittests to Mac10.{9,9(dbg),10,11} and asan bots

Disable a few tests we haven't gotten to fixing yet, since it's more
important to get the rest into continuous integration at this point.

Will land this at a quiet time on the weekend, and monitor closely
for potential flakes or other problems.

Recently added tests disabled due to missing GetGlobalCapture()
implementation:
 - MenuRunnerTest.WidgetDoesntTakeCapture
 - WidgetTest.MousePressCausesCapture
 - WidgetTest.CaptureDuringMousePressNotOverridden

Disabled on 10.9 only (different native Textfield behaviour):
 - BridgedNativeWidgetTest.TextInput_MoveEditingCommands
 - BridgedNativeWidgetTest.TextInput_DeleteCommands

Also disables:
 - WidgetTest.FullscreenFrameLayout [fails only on bots]
 - StyledLabelTest.StyledRangeBold [fails only on 10.10]

But the other ~720 tests pass.

Disables tests for recent regressions in r401862 and r401987. We need
that continuous integration - stat!

BUG= 500806 ,  621734 ,  622979 ,  622983 ,  622979 ,  607403 ,  623420 ,  623421 

Review-Url: https://codereview.chromium.org/1925943002
Cr-Commit-Position: refs/heads/master@{#402103}

[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/cocoa/bridged_native_widget_unittest.mm
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/1ce26dc83bff3f79f27b698f9cddeb7d9470949a/ui/views/widget/widget_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3ce4a9c327dcacf9a50792218fb79a794dae518

commit d3ce4a9c327dcacf9a50792218fb79a794dae518
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Jun 28 03:37:52 2016

MacViews: Fix failing mouse capture unittests.

This CL implements NativeWidgetPrivate::GetGlobalCapture for NativeWidgetMac.
This was added in crrev.com/1953753002. This fixes the following three unittests
which fail on MacViews:
  -WidgetTest.MousePressCausesCapture
  -WidgetTest.CaptureDuringMousePressNotOverridden
  -MenuRunnerTest.WidgetDoesntTakeCapture

This CL also fixes the EventGeneratorDelegateMac::CenterOfWindow implementation
which incorrectly returns the center point in screen coordinates while other
EventGeneratorDelegateMac methods assume the window coordinates as the root
coordinate system. This is needed for the three tests above to pass, since they
don't specify an explicit event location for the EventGenerator.

BUG= 622979 ,  607403 

Review-Url: https://codereview.chromium.org/2096993002
Cr-Commit-Position: refs/heads/master@{#402388}

[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_delegate.h
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/cocoa/cocoa_mouse_capture_unittest.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/test/event_generator_delegate_mac.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/d3ce4a9c327dcacf9a50792218fb79a794dae518/ui/views/widget/widget_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1373d81bf918bd38991cb3bd790834fe53189632

commit 1373d81bf918bd38991cb3bd790834fe53189632
Author: karandeepb <karandeepb@chromium.org>
Date: Tue Jun 28 03:43:08 2016

MacViews: Fix BridgedNativeWidget.* tests which fail on OSX 10.9.

This CL fixes the following views_unittests which fail on OSX 10.9-
  -BridgedNativeWidgetTest.TextInput_DeleteCommands
  -BridgedNativeWidgetTest.TextInput_MoveEditingCommands

The reason for these failures is that an NSTextView on 10.9 behaves weirdly if
initialized with an NSZeroRect as its frame rectangle. Changing the frame
rectangle to a larger one fixes the tests.

BUG= 621734 ,  607403 

Review-Url: https://codereview.chromium.org/2093003002
Cr-Commit-Position: refs/heads/master@{#402394}

[modify] https://crrev.com/1373d81bf918bd38991cb3bd790834fe53189632/ui/views/cocoa/bridged_native_widget_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c48ee3ccb04d21a17e14428d15c64d17b3033f

commit 84c48ee3ccb04d21a17e14428d15c64d17b3033f
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Jun 29 04:09:15 2016

MacViews: Modify cocoa_test_event_utils::SynthesizeKeyEvent to use the correct event timestamp value.

This CL fixes the following views_unittests, currently disabled on MacViews-
  -TextfieldTest.DestroyingTextfieldFromOnKeyEvent
  -TextfieldTest.FocusTraversalTest
  -TextfieldTest.TextInputClientTest

These regressed in crrev.com/2007083002, which added a DCHECK to validate that
ui::Event::time_stamp comes from the same clock as TimeTicks::Now. These tests
fail since we are using a mocked system clock in tests, set using
SetEventTickClockForTesting in base_event_utils.h, against which the event
timestamp is validated. However cocoa_test_event_utils::SynthesizeKeyEvent uses
the actual/correct timestamp value, and not the mocked one.

This CL fixes the tests by using a timestamp value obtained from
ui::EventTimeForNow. This returns the mocked time (if applicable), or
base::TimeTicks::Now(). base::TimeTicks::Now() internally uses the same logic as
TimeIntervalSinceSystemStartup() did previously (i.e. mach_absolute_time()).

BUG= 623420 ,  607403 

Review-Url: https://codereview.chromium.org/2101903002
Cr-Commit-Position: refs/heads/master@{#402708}

[modify] https://crrev.com/84c48ee3ccb04d21a17e14428d15c64d17b3033f/ui/events/test/cocoa_test_event_utils.h
[modify] https://crrev.com/84c48ee3ccb04d21a17e14428d15c64d17b3033f/ui/events/test/cocoa_test_event_utils.mm
[modify] https://crrev.com/84c48ee3ccb04d21a17e14428d15c64d17b3033f/ui/views/controls/textfield/textfield_unittest.cc

The only thing left here is WidgetTest.FullscreenFrameLayout

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

-> Phase4 for fullscreen

10.9 support is gone, WontFix.

we should remove the 

#if defined(OS_MACOSX)
#define MAYBE_FullscreenFrameLayout DISABLED_FullscreenFrameLayout

in widget_unittest.cc :)

https://chromium-review.googlesource.com/c/chromium/src/+/986534

** Bulk Edit **

There are only two M67 dev releases left on 04/03 & 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.

Cl listed at #20 passed the CQ dry run.
ellyjones@, is it ready to commit now?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85bcb95ded458d874f3780b74bc16d7f5e780f98

commit 85bcb95ded458d874f3780b74bc16d7f5e780f98
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri Mar 30 17:20:15 2018

views: reenable WidgetTest.FullscreenFrameLayout on Mac

This test was disabled because it failed on 10.9 bots (which is not
surprising - 10.9 had an entirely different fullscreen system) but we
no longer support 10.9, nor do we have any more 10.9 bots.

Bug:  607403 
Change-Id: I01098a3100f2499de315f5043774b9f2eaccfd06
Reviewed-on: https://chromium-review.googlesource.com/986534
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547197}
[modify] https://crrev.com/85bcb95ded458d874f3780b74bc16d7f5e780f98/ui/views/widget/widget_unittest.cc