Running a self-compiled gn binary doesn't work on Ubuntu armhf
Reported by
saiarcot...@gmail.com,
Apr 28 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2679.0 Chrome/51.0.2679.0 Safari/537.36 Steps to reproduce the problem: 1. Compile gn from the source code in the Chromium repo on an Ubuntu armhf system 2. Attempt to run gn to compile Chromium What is the expected behavior? What went wrong? gn fails with "OS architecture not handled.". Did this work before? N/A Chrome version: 51.0.2679.0 Channel: n/a OS Version: Flash Version: It seems in the OS detection code that 'os_arch.substr(3) == "arm"' is run, which grabs the value of os_arch from index 3 to the end. However, on Ubuntu systems at least (and likely other Linux systems), "arm" is the first three letters, and that call should probably be os_arch.substr(0, 3) instead, which does work.
,
Apr 28 2016
,
Apr 28 2016
I've uploaded a possible fix for review at https://codereview.chromium.org/1920033007/.
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68180a770804afde260b0f1c9747f10139b20b3 commit b68180a770804afde260b0f1c9747f10139b20b3 Author: saiarcot895 <saiarcot895@gmail.com> Date: Thu Apr 28 22:25:01 2016 Fix arm detection code in gn. The current code calls substr(3), which gets the substring starting from index 3 up to the end of the string. However, on Ubuntu armhf (and likely other systems), arm is the first three characters, and the original intention was likely to get the substring of length 3 starting from the beginning of the string. R=brettw@chromium.org BUG= 607385 Review-Url: https://codereview.chromium.org/1920033007 Cr-Commit-Position: refs/heads/master@{#390507} [modify] https://crrev.com/b68180a770804afde260b0f1c9747f10139b20b3/tools/gn/args.cc
,
May 10 2016
This issue is fixed and can be closed.
,
May 10 2017
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue. The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 10 2017
The patch in comment 4 may have fixed this. If not, this isn't something we officially support anyway. |
||||
►
Sign in to add a comment |
||||
Comment 1 by thestig@chromium.org
, Apr 28 2016