New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607373 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Move Cast-related certificate verification code from extensions to components

Project Member Reported by ryanchung@chromium.org, Apr 28 2016

Issue description

Refactor Cast-related certificate verification code from //extensions/common/cast to //components/? 

This allows Cast platform to also utilize the same Cast certificate verification logic that is currently used by the Cast browser extension.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d318d76b90c04216eff4ffcf9f0a06d122708589

commit d318d76b90c04216eff4ffcf9f0a06d122708589
Author: ryanchung <ryanchung@chromium.org>
Date: Thu May 05 17:22:12 2016

Move Cast certificate verification code from extensions to components.

The Cast certificate verification code was previously only used by the
Cast extension. Cast platform would also like to use this code. It did
not make sense to leave this code in extensions as extensions is disabled
on platforms like Android while Cast supports Android TVs.

This CL moves //extensions/common/cast to //components/cast_certificate.
The associated unittests are now included in the components unittests.
Test data for these unittests relocated from //extensions/test/data to
//components/test/data.

BUG= 607373 

Review-Url: https://codereview.chromium.org/1924323002
Cr-Commit-Position: refs/heads/master@{#391834}

[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/chrome/chrome_common.gypi
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/chrome/common/BUILD.gn
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/chrome/common/DEPS
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/chrome/common/extensions/api/networking_private/networking_private_crypto.cc
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/BUILD.gn
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/OWNERS
[add] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate.gypi
[add] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/BUILD.gn
[add] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/DEPS
[add] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/OWNERS
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_cert_validator.cc
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_cert_validator.h
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_cert_validator_test_helpers.cc
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_cert_validator_test_helpers.h
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_cert_validator_unittest.cc
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/cast_root_ca_cert_der-inc.h
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/cast_certificate/eureka_root_ca_der-inc.h
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/components.gyp
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/components_tests.gyp
[add] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/OWNERS
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/audio_ref_dev_test_chain_3.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/cast_root_ca.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/chromecast_audio.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/chromecast_gen1.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/chromecast_gen1_reissue.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/chromecast_gen2.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/eureka_ca.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/fugu.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/mtk_audio_dev.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/unchained.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/certificates/vizio.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/signeddata/2ZZBG9_FA8FCA3EF91A.pem
[rename] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/components/test/data/cast_certificate/signeddata/AudioReferenceDevTest.pem
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/BUILD.gn
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/browser/BUILD.gn
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/browser/api/cast_channel/DEPS
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/browser/api/cast_channel/cast_auth_util.cc
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/browser/api/cast_channel/cast_auth_util_unittest.cc
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/extensions.gyp
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/extensions.gypi
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/extensions_tests.gyp
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/extensions_tests.gypi
[modify] https://crrev.com/d318d76b90c04216eff4ffcf9f0a06d122708589/extensions/extensions_unittests.isolate

Status: Fixed (was: Started)
How do I do what your asking me I have no idea what I have done and did not
mean to do this

sent from bush my tablet

Sign in to add a comment