New issue
Advanced search Search tips

Issue 607362 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 433082



Sign in to add a comment

port video_{de,en}code_accelerator_unittest, bitmaptools to GN for ChromeOS

Project Member Reported by dpranke@chromium.org, Apr 27 2016

Issue description

video_decode_accelerator_unittest has been ported to GN on Android, but I think it likely needs some CrOS-specific stuff as well.

video_encode_accelerator_unittest hasn't been ported at all.

Both of them are normally built on the simplechrome bots as part of the chromium_preflight queue, but are commented out at the moment.
 
Summary: port video_{de,en}code_accelerator_unittest, bitmaptools to GN for ChromeOS (was: port video_{de,en}code_accelerator_unittest to GN for ChromeOS)
It also looks like chromiumos_preflight depends on bitmaptools but we hit a compile error for that one that should be fixed ...

http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/129162
Cc: dpranke@chromium.org
 Issue 597165  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f92633b8307d2a2d1af20e0d5915942b6a03d15d

commit f92633b8307d2a2d1af20e0d5915942b6a03d15d
Author: dpranke <dpranke@chromium.org>
Date: Thu Apr 28 04:33:34 2016

Flip trybot and waterfall bot for simplechrome amd64 to GN.

This is another attempt at flipping the first simplechrome bots to GN.

R=stevenjb@chromium.org
BUG= 433082 ,  607362 

Review-Url: https://codereview.chromium.org/1926963002
Cr-Commit-Position: refs/heads/master@{#390298}

[modify] https://crrev.com/f92633b8307d2a2d1af20e0d5915942b6a03d15d/BUILD.gn
[modify] https://crrev.com/f92633b8307d2a2d1af20e0d5915942b6a03d15d/tools/mb/mb_config.pyl

Woot, this appears to be working! Let's flip the rest of them.
Yup, will post another CL shortly.
Note: last 3 comments should really apply to  issue 605154 

Owner: steve...@chromium.org
Status: Started (was: Available)
This looks straightforward...

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3002ea53f5070f13db473184f0997686b4ca81cb

commit 3002ea53f5070f13db473184f0997686b4ca81cb
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Apr 29 20:13:32 2016

GN: Add video_{de,en}code_accelerator_unittest targets

BUG= 607362 

Review-Url: https://codereview.chromium.org/1929053003
Cr-Commit-Position: refs/heads/master@{#390731}

[modify] https://crrev.com/3002ea53f5070f13db473184f0997686b4ca81cb/content/test/BUILD.gn

Status: Fixed (was: Started)
Bulk verified
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment