New issue
Advanced search Search tips

Issue 607359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 584077



Sign in to add a comment

Recipe roller doesn't allow unicode characters in commits it rolls.

Project Member Reported by martiniss@chromium.org, Apr 27 2016

Issue description

See https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/recipe-autoroller-internal/builds/927 and the "bad" commit at https://crrev.com/36ffdc3f800aa4a6153de0e4626a204c8bef6a92

Solution appears to be to make git cl able to set the description another way. I'll be working on a CL to add that to git cl.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/b73176a772e3b8d9a84e52a9104c1cbe1926edae

commit b73176a772e3b8d9a84e52a9104c1cbe1926edae
Author: martiniss@chromium.org <martiniss@chromium.org>
Date: Fri Apr 29 17:13:55 2016

git_cl: Add the ability to set the description.

BUG= 607359 

Review-Url: https://codereview.chromium.org/1922133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300357 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/b73176a772e3b8d9a84e52a9104c1cbe1926edae/git_cl.py
[modify] https://crrev.com/b73176a772e3b8d9a84e52a9104c1cbe1926edae/tests/git_cl_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/81d04c18ee335794ce69c0bbdc3f7d721b4262f2

commit 81d04c18ee335794ce69c0bbdc3f7d721b4262f2
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Fri Apr 29 17:26:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/b73176a772e3b8d9a84e52a9104c1cbe1926edae git_cl: Add the ability to set the description. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG= 607359 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1929393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300358 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/81d04c18ee335794ce69c0bbdc3f7d721b4262f2/infra/config/recipes.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87226

------------------------------------------------------------------
r87226 | recipe-roller@chromium.org | 2016-04-29T17:42:53.933271Z

-----------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/611cd7ab027c90efae0652bd961eb24c709c67f2

commit 611cd7ab027c90efae0652bd961eb24c709c67f2
Author: martiniss@chromium.org <martiniss@chromium.org>
Date: Fri Apr 29 18:21:43 2016

Revert of git_cl: Add the ability to set the description. (patchset #3 id:40001 of https://codereview.chromium.org/1922133006/ )

Reason for revert:
splitlines man

Original issue's description:
> git_cl: Add the ability to set the description.
> 
> BUG= 607359 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300357

TBR=iannucci@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 607359 

Review-Url: https://codereview.chromium.org/1935633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300360 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/611cd7ab027c90efae0652bd961eb24c709c67f2/git_cl.py
[modify] https://crrev.com/611cd7ab027c90efae0652bd961eb24c709c67f2/tests/git_cl_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/40972de98733d2dd323ffb712565ad54508822da

commit 40972de98733d2dd323ffb712565ad54508822da
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Fri Apr 29 18:36:05 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/611cd7ab027c90efae0652bd961eb24c709c67f2 Revert of git_cl: Add the ability to set the description. (patchset #3 id:40001 of https://codereview.chromium.org/1922133006/ ) (martiniss@chromium.org)

R=iannucci@chromium.org,martiniss@chromium.org,tandrii@chromium.org
BUG= 607359 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1933873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300361 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/40972de98733d2dd323ffb712565ad54508822da/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87229

------------------------------------------------------------------
r87229 | recipe-roller@chromium.org | 2016-04-29T18:43:05.251372Z

-----------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/d6648e2d3a551d9adc5f2c9234cd12a1aeb12124

commit d6648e2d3a551d9adc5f2c9234cd12a1aeb12124
Author: martiniss@chromium.org <martiniss@chromium.org>
Date: Fri Apr 29 19:22:16 2016

git_cl: Add the ability to set the description. (reland)

BUG= 607359 

Review-Url: https://codereview.chromium.org/1935653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300366 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/d6648e2d3a551d9adc5f2c9234cd12a1aeb12124/git_cl.py
[modify] https://crrev.com/d6648e2d3a551d9adc5f2c9234cd12a1aeb12124/tests/git_cl_test.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/49c3922f789bcaf0443e1789007f0bec14a58b43

commit 49c3922f789bcaf0443e1789007f0bec14a58b43
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Fri Apr 29 19:36:12 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/d6648e2d3a551d9adc5f2c9234cd12a1aeb12124 git_cl: Add the ability to set the description. (reland) (martiniss@chromium.org)

R=martiniss@chromium.org
BUG= 607359 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1938573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300368 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/49c3922f789bcaf0443e1789007f0bec14a58b43/infra/config/recipes.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87239

------------------------------------------------------------------
r87239 | recipe-roller@chromium.org | 2016-04-29T19:43:00.188087Z

-----------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/180246af433d9d35ac15057a78525deec3868b02

commit 180246af433d9d35ac15057a78525deec3868b02
Author: recipe-roller@chromium.org <recipe-roller@chromium.org>
Date: Fri Apr 29 20:46:40 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/28216cd14b44716db5c83634afbdc6e90492652b Add git_cl recipe module. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG= 607359 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/1935553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300373 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/180246af433d9d35ac15057a78525deec3868b02/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87246

------------------------------------------------------------------
r87246 | recipe-roller@chromium.org | 2016-04-29T21:03:15.803699Z

-----------------------------------------------------------------
Status: Assigned (was: Started)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
This has landed.

Sign in to add a comment