Strange window title coloring in GMail compose window under Material Design |
||
Issue descriptionVersion: 52.0.2715.0 OS: 10.11 What steps will reproduce the problem? (1) Log into GMail (2) Shift-click the Compose button What is the expected output? A new GMail compose window appears with a normal title bar. What do you see instead? The area behind the title text is drawn in a different color than the rest of the title bar.
,
May 12 2016
,
May 12 2016
Another way to replicate this is to download the "Open-as-popup" extension and then change the browser window into a popup Anyway, it looks like this issue occurs because a NSVisualEffectView gets inserted in Material design. I find that if we remove NSVisualEffectView, the titlebar text will like fine (see attached). Is it alright if we don’t add the NSVisualEffectView for popups? Otherwise, changing the text background for the titlebar will have to involve some hacking since it’s not easily accessible with us. I have some ideas I’ve currently experimenting with, such as swizzling _drawTitleStringIn:withColor:
,
May 12 2016
Ah, I see. I didn't really know about this class of window. Yes, in this case we should not add an NSVisualEffectView.
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32810807ecda6e6a65666c7ec66590b02e89167f commit 32810807ecda6e6a65666c7ec66590b02e89167f Author: spqchan <spqchan@chromium.org> Date: Fri May 13 22:51:54 2016 [Material][Mac] Remove NSVisualEffectView from windows with titlebars BUG= 607356 Review-Url: https://codereview.chromium.org/1974733003 Cr-Commit-Position: refs/heads/master@{#393664} [modify] https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f/chrome/browser/ui/cocoa/tabs/tab_window_controller.h [modify] https://crrev.com/32810807ecda6e6a65666c7ec66590b02e89167f/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
May 13 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by shrike@chromium.org
, May 10 2016Owner: spqc...@chromium.org
Summary: Strange window title coloring in GMail compose window under Material Design (was: Strange window title coloring in GMail compose window)
9.5 KB
9.5 KB View Download
8.8 KB
8.8 KB View Download