testEMEPermission failure on chromium.android WebView L and M bot |
|||
Issue descriptionThe failure is only on AOSP build Android because AOSP Android doesn't support the DRM scheme (widevine) offered by Google and used by Chrome (OEM partners need to have a contract with Google to get the widevine source) Therefore, the upstream bot fails on testEMEPermission. Not sure whether I should delete the test case or add DisableIf annotation condition to it?
,
May 4 2016
Please don't leave failing tests on teh waterfall for a week - when you found the test was broken you should have either reverted the change or disabled the test right away. The bot has since started failing *other* tests as well, but nobody has paid any attention because it was already broken by your change :/
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b8866014d743f8ee4fd9a5229f7ec28334b46b7 commit 8b8866014d743f8ee4fd9a5229f7ec28334b46b7 Author: timvolodine <timvolodine@chromium.org> Date: Wed May 04 14:13:01 2016 [WebViewLayoutTests] Disable failing testEMEPermission layout test. Disable the EME test which is currently failing on AOSP bots. BUG= 607350 Review-Url: https://codereview.chromium.org/1946203003 Cr-Commit-Position: refs/heads/master@{#391502} [modify] https://crrev.com/8b8866014d743f8ee4fd9a5229f7ec28334b46b7/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java
,
May 4 2016
+torne, sorry, that was my mistake. Will do in the future
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea1675fb67d48828efb8c6b168582aa9f33388a2 commit ea1675fb67d48828efb8c6b168582aa9f33388a2 Author: yolandyan <yolandyan@google.com> Date: Wed Jun 08 20:28:38 2016 Add DisableIf annotation to EME test EME test does not pass on AOSP Android, therefore, add DisableIf annotation to it (from BaseInstrumentationTestRunner) Reorganized BaseInstrumentationTestRunner so it doesn't include anything unrelated to WebViewLayout Testing. BUG= 607350 Review-Url: https://codereview.chromium.org/1952573002 Cr-Commit-Position: refs/heads/master@{#398659} [modify] https://crrev.com/ea1675fb67d48828efb8c6b168582aa9f33388a2/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java [modify] https://crrev.com/ea1675fb67d48828efb8c6b168582aa9f33388a2/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTestRunner.java [modify] https://crrev.com/ea1675fb67d48828efb8c6b168582aa9f33388a2/base/test/android/javatests/src/org/chromium/base/test/util/DisableIf.java [modify] https://crrev.com/ea1675fb67d48828efb8c6b168582aa9f33388a2/base/test/android/javatests/src/org/chromium/base/test/util/DisableIfSkipCheck.java
,
Jun 24 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yolandyan@chromium.org
, May 4 2016