Issue 607349 link

Starred by 4 users

Issue metadata

Status:	Fixed
Owner:	dtapu...@chromium.org
Closed:	Jul 2016
Cc:	█ chongz@chromium.org garykac@chromium.org
Components:	Blink>Input
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Launch-OWP
Launch-Accessibility:	----
Launch-Exp-Leadership:	----
Launch-Leadership:	----
Launch-Legal:	----
Launch-M-Approved:	----
Launch-M-Target:	----
Launch-Privacy:	----
Launch-Security:	----
Launch-Test:	----
Launch-UI:	----
Rollout-Type:	----
M-54 Hotlist-Input-Dev

Deprecate and Remove KeyboardEvent.keyIdenfitier

Project Member Reported by dtapu...@chromium.org, Apr 27 2016

Issue description

Now that KeyboardEvent.key has shipped we should deprecate the non-standard keyIdentifier.

Comment 1 by dtapu...@chromium.org, Apr 29 2016

Intent to remove:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

Chrome Status Entry:
https://www.chromestatus.com/features/5316065118650368

Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed99b4d4aa6d128426053d0532ad082312010b0a

commit ed99b4d4aa6d128426053d0532ad082312010b0a
Author: dtapuska <dtapuska@chromium.org>
Date: Mon May 02 19:09:41 2016

Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG= 607349 

Review-Url: https://codereview.chromium.org/1932293002
Cr-Commit-Position: refs/heads/master@{#391020}

[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/init-events-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/js-keyboard-event-creation-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/fast/events/special-key-events-in-input-text-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/Source/core/events/KeyboardEvent.idl
[modify] https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 3 by dtapu...@chromium.org, May 4 2016

Status: Started (was: Assigned)
Summary: Deprecate and Remove KeyboardEvent.keyIdenfitier (was: Deprecate KeyboardEvent.keyIdenfitier)

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96d32db9c9cf09cbf291d85533bfd5386e9319f2

commit 96d32db9c9cf09cbf291d85533bfd5386e9319f2
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Jun 06 15:19:25 2016

Allow the exact DOM Code value to be sent from layout tests.

With the conversion to keyIdentifier there are some issues that need
to be fixed with layout tests. Add the exact string identifiers to
event_sender so that it is clear between the LayoutTests
and the implementation the identifier can be the same.

BUG= 607349 

Review-Url: https://codereview.chromium.org/2039233002
Cr-Commit-Position: refs/heads/master@{#398030}

[modify] https://crrev.com/96d32db9c9cf09cbf291d85533bfd5386e9319f2/components/test_runner/event_sender.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0

commit 8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Jun 07 21:39:48 2016

Add code and key into the browser test key simulation methods.

With the soon to be removal of keyboardIdentifier it is necessary
that events generated from the test suites actually have the correct
key value.

BUG= 607349 

Review-Url: https://codereview.chromium.org/2048533002
Cr-Commit-Position: refs/heads/master@{#398385}

[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/chromeos/input_method/textinput_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/password_manager/password_manager_interactive_uitest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/site_per_process_interactive_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/test/remoting/remote_desktop_browsertest.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/chrome/test/remoting/remote_desktop_browsertest.h
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/8b1bdc8fad9b6f980aa7e86c3dfbc0f75e48f1e0/content/public/test/browser_test_utils.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feff0d5843bf7a3c3ecdd682f77c39a43e75030a

commit feff0d5843bf7a3c3ecdd682f77c39a43e75030a
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Jun 08 02:29:50 2016

Send 'key' from fake keyboard events generated by file_manager.

With the deprecation of keyIdentifier; the key variable needs to be
sent on the unit tests generating keyboard events.

BUG= 607349 

Review-Url: https://codereview.chromium.org/2046143002
Cr-Commit-Position: refs/heads/master@{#398464}

[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/file_manager/background/js/test_util_base.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/create_new_folder.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/drive_specific.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/file_dialog.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/gear_menu.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/file_manager/tab_index.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/gallery/open_image_files.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/gallery/photo_editor.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/gallery/thumbnail_mode.js
[modify] https://crrev.com/feff0d5843bf7a3c3ecdd682f77c39a43e75030a/ui/file_manager/integration_tests/remote_call.js

Comment 7 by rbyers@chromium.org, Jun 8 2016

Looks like the NTP is using keyIdentifier still too, please fix this (kind of embarassing to have deprecation warnings for Chrome code)!

https://cs.chromium.org/chromium/src/chrome/browser/resources/ntp4/page_list_view.js?q=onDocKeyDown&sq=package:chromium&l=730&dr=C

Comment 8 by dtapu...@chromium.org, Jun 8 2016

I was told some of the code had to remain because of iOS not supporting key.
Do we know what is imported into iOS?

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252

commit 8b270d000b1dde4f6a15aad583ba8dd8fdcb4252
Author: dtapuska <dtapuska@chromium.org>
Date: Sat Jun 11 16:06:19 2016

Handle the "key" field as opposed to keyIdentifier field.

keyIdentifier will be deprecated soon so we need to move over to the
standardized identifier.

Approved Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG= 607349 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2045603002
Cr-Commit-Position: refs/heads/master@{#399369}

[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/dom/fragment-activation-focuses-target.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/backspace-navigates-back.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/simulated-key-state-expected.txt
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/http/tests/navigation/same-and-different-back.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-test.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-trimmed-attribute-value.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-aware-property-value-edit.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-blank-property.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-tab.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-cancel-editing.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/undo-after-cancelled-editing.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/MediaDocument.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/KeyboardClickableInputTypeView.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252

commit 8b270d000b1dde4f6a15aad583ba8dd8fdcb4252
Author: dtapuska <dtapuska@chromium.org>
Date: Sat Jun 11 16:06:19 2016

Handle the "key" field as opposed to keyIdentifier field.

keyIdentifier will be deprecated soon so we need to move over to the
standardized identifier.

Approved Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG= 607349 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2045603002
Cr-Commit-Position: refs/heads/master@{#399369}

[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/dom/fragment-activation-focuses-target.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/backspace-navigates-back.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/simulated-key-state-expected.txt
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/http/tests/navigation/same-and-different-back.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-test.js
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/edit/edit-trimmed-attribute-value.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-1/color-aware-property-value-edit.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-blank-property.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-add-new-rule-tab.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles-3/styles-cancel-editing.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/undo-after-cancelled-editing.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/MediaDocument.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/KeyboardClickableInputTypeView.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/8b270d000b1dde4f6a15aad583ba8dd8fdcb4252/third_party/WebKit/Source/web/tests/WebViewTest.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb476ec391db39b6334519844e555c0711cd02d1

commit bb476ec391db39b6334519844e555c0711cd02d1
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Jun 15 16:14:17 2016

Remove keyIdentifier usage in chrome/browser/resources/*

This removes the majority of the keyIdentifier usages in the browser
resources. Replace the usage with the formally specified 'key' field.

No functional changes intended.

BUG= 607349 
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2059913002
Cr-Commit-Position: refs/heads/master@{#399913}

[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/login/screen_supervised_user_creation.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/sim_unlock.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/user_images_grid.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/extensions/chromeos/kiosk_apps.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/extensions/extension_error.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/history/history.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/hotword_audio_verification/main.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/inspect/inspect.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/ntp4/apps_page.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/ntp4/dot_list.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/ntp4/nav_dot.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/ntp4/page_list_view.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/ntp4/tile_page.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/chromeos/accounts_user_name_edit.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/chromeos/network_list.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/cookies_list.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/cookies_view.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/editable_text_field.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/home_page_overlay.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/inline_editable_list.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/language_dictionary_overlay.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/options/language_options.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/resources/sync_confirmation/sync_confirmation.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/ui/webui/options/cookies_view_browsertest.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/browser/ui/webui/options/edit_dictionary_browsertest.js
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/test/data/keyevents_test.html
[modify] https://crrev.com/bb476ec391db39b6334519844e555c0711cd02d1/chrome/test/data/webui/link_controller_test.html

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38625c390884254b2edb178e7e0ca1c301817002

commit 38625c390884254b2edb178e7e0ca1c301817002
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Jun 22 21:58:33 2016

Eradicate keyIndentifier from devtools/*

keyIdentifier is going to be deprecated; we need to stop using it.

No functional changes intended. A few instances remain with respect
to extensions and keyIdentifier. Those need to be handled so that
we don't break existing extensions.

BUG= 607349 

Review-Url: https://codereview.chromium.org/2033403005
Cr-Commit-Position: refs/heads/master@{#401423}

[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/chrome/chrome_debugger.gypi
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/LayoutTests/inspector/console/console-auto-completion.html
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/devtools.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/ForwardedInputEventHandler.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/ShortcutRegistry.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js
[modify] https://crrev.com/38625c390884254b2edb178e7e0ca1c301817002/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d

commit 89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Jul 04 21:07:11 2016

Convert Event#keyIdentifier (deprecated) to Event#key

BUG= 607349 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2104103002
Cr-Commit-Position: refs/heads/master@{#403715}

[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/browser/resources/chromeos/wallpaper_manager/main.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/browser/ui/webui/options/options_browsertest.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr/ui/list_selection_controller.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/renderer/resources/plugins/plugin_poster.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/test/data/webui/history_browsertest.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/chrome/test/data/webui/inline_editable_list_test.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/file_manager/file_manager/foreground/js/ui/actions_submenu_unittest.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/login/account_picker/user_pod_row.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/login/bubble.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/action_link.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/link_controller.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/autocomplete_list.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/command.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/context_menu_handler.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/focus_grid.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/focus_row.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/list_selection_controller.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/menu.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/menu_button.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/menu_item.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/overlay.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/tabs.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/cr/ui/tree.js
[modify] https://crrev.com/89d8be5e8dac40428d4fc8dab1a7151cdc4bf78d/ui/webui/resources/js/util.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5518dc829d2a338abd76f4812813329f0df40aa9

commit 5518dc829d2a338abd76f4812813329f0df40aa9
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jul 07 00:35:17 2016

Remove keyIdentifier.

KeyboardEvent.key and KeyboardEvent.code are the replacements for
KeyboardEvent.keyIdentifier.

Approved intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG= 607349 

Review-Url: https://codereview.chromium.org/2120153003
Cr-Commit-Position: refs/heads/master@{#404015}

[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/components/test_runner/event_sender.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/components/test_runner/text_input_controller.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/input/web_input_event_builders_win.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/native_web_keyboard_event_aura.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/browser/renderer_host/web_input_event_aura.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/common/input/web_input_event_traits.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/content/renderer/pepper/event_conversion.cc
[add] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/mojo/converters/blink/OWNERS
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/mojo/converters/blink/blink_input_events_type_converters.cc
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/init-events-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/js-keyboard-event-creation-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/js-keyboard-event-creation.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/script-tests/init-events.js
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/special-key-events-in-input-text-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/events/special-key-events-in-input-text.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/forms/radio/radio-crash-by-keyboard-event.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/fast/html/eventhandler-attribute-non-callable.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-focus.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/core/events/KeyboardEvent.h
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/core/events/KeyboardEvent.idl
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/core/events/KeyboardEventInit.idl
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/platform/PlatformKeyboardEvent.h
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/5518dc829d2a338abd76f4812813329f0df40aa9/third_party/WebKit/public/web/WebInputEvent.h

Comment 15 by dtapu...@chromium.org, Jul 7 2016

Status: Fixed (was: Started)

Comment 16 by dtapu...@chromium.org, Jul 7 2016

Labels: M-54

Comment 17 by zxcvbnmf...@gmail.com, Aug 13 2016

hey theiir everyone im georgr im 20 already taken some community classes in coding understand 4 semesters worth but is this

https://www.chromestatus.com/features/5316065118650368
 and also https://www.chromestatus.com/features/6750456638341120

are these not going to be fiixed for a while i need these fixed and dont know how dont know how also a virus has made its self address is so my administrator when my dad is and this is administrator account but clicking on an icon when i open up search enginges i cant change defualt even though im on administrator account

my chrome it stuck to this home page when i open up chrome http://www.safesear.ch/?type=20160512-135-ch-dr ior varATION OF SOMEONE HELP?

►

Issue 607349 link

Issue metadata

Deprecate and Remove KeyboardEvent.keyIdenfitier

Issue description

Comment 1 by dtapu...@chromium.org, Apr 29 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, May 2 2016

Comment 2 Deleted

Comment 3 by dtapu...@chromium.org, May 4 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 6 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 7 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jun 8 2016

Comment 6 Deleted

Comment 7 by rbyers@chromium.org, Jun 8 2016

Comment 7 Deleted

Comment 8 by dtapu...@chromium.org, Jun 8 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jun 11 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jun 22 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jul 4 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jul 7 2016

Comment 14 Deleted

Comment 15 by dtapu...@chromium.org, Jul 7 2016

Comment 15 Deleted

Comment 16 by dtapu...@chromium.org, Jul 7 2016

Comment 16 Deleted

Comment 17 by zxcvbnmf...@gmail.com, Aug 13 2016

Comment 17 Deleted

Sign in to add a comment