New issue
Advanced search Search tips

Issue 607348 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 546836
issue 614588
issue 614589



Sign in to add a comment

[Autofill] Update Credit Cards to Material Design

Project Member Reported by hcarmona@chromium.org, Apr 27 2016

Issue description

Issue to track progress for this section.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2016

Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83216ec07f04aa199a9de9a6e4a66c45696df84c

commit 83216ec07f04aa199a9de9a6e4a66c45696df84c
Author: hcarmona <hcarmona@chromium.org>
Date: Tue May 17 02:44:38 2016

Implement autofill Address and Credit Card lists.

This CL includes tests to verify UI.
Regenerates the private API in order to ensure closure compile.
API is not called to populate UI w/ real data, will be followup CL.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1947293002
Cr-Commit-Position: refs/heads/master@{#394032}

[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[add] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/chrome_tests.gypi
[add] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/third_party/closure_compiler/externs/autofill_private.js

Project Member

Comment 3 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b609f48aa006b1fce36c7c9b1edd31cf766aca6c

commit b609f48aa006b1fce36c7c9b1edd31cf766aca6c
Author: hcarmona <hcarmona@chromium.org>
Date: Fri May 20 23:32:38 2016

Add context menus in md-setting for the address and credit card lists.

Menus will show/hide appropriately.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1992043002
Cr-Commit-Position: refs/heads/master@{#395199}

[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f900222890dd7e4d6ca6ac872520b6ee9c518f04

commit f900222890dd7e4d6ca6ac872520b6ee9c518f04
Author: hcarmona <hcarmona@chromium.org>
Date: Mon May 23 23:29:21 2016

Separate the listeners and getters for the Autofill Private API.

OnAddressListChanged and OnCreditCardListChanged used to trigger an
update when a listener was added. This is now de-coupled so that a list
can be retrieved separately from listening for changes.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1957043002
Cr-Commit-Position: refs/heads/master@{#395462}

[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/chrome_tests.gypi
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/extensions/api_test/autofill_private/test.js
[add] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[add] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/tools/metrics/histograms/histograms.xml

Components: UI>Settings
Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-PasswordsForms
Labels: Pri-1
Labels: OS-All
Labels: Hotlist-MD-DevBlocker
Blocking: 614588
Blocking: 614589
Labels: -Hotlist-MD-DevBlocker
Cc: bettes@chromium.org
Screenshots for https://codereview.chromium.org/2015463003/
add_cc.png
44.5 KB View Download
edit_cc.png
45.5 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea2730123956cc7cd538919573330f7c3dccb493

commit ea2730123956cc7cd538919573330f7c3dccb493
Author: hcarmona <hcarmona@chromium.org>
Date: Fri May 27 19:59:02 2016

Saved addresses and credit cards can be removed from md-settings.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2008273003
Cr-Commit-Position: refs/heads/master@{#396544}

[modify] https://crrev.com/ea2730123956cc7cd538919573330f7c3dccb493/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/ea2730123956cc7cd538919573330f7c3dccb493/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02e2448d903564a3199edc570835c2eabdf12b7

commit a02e2448d903564a3199edc570835c2eabdf12b7
Author: hcarmona <hcarmona@chromium.org>
Date: Mon Jun 06 21:37:06 2016

Add dialog to edit and save credit cards.

Tests included for dialog.
Screenshots in bug.

BUG= 607348 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2015463003
Cr-Commit-Position: refs/heads/master@{#398133}

[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/app/settings_strings.grdp
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[add] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[add] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/a02e2448d903564a3199edc570835c2eabdf12b7/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Cc: tbuck...@chromium.org
The only thing missing from section is to differentiate between Credit Cards that are stored in Chrome and CC's that are coming from Google Payments.

Mocks do not differentiate sources. CC's from Google Payments can only be edited by visiting the google payments site.
For now, let's put "Google Payments" in a lighter gray font next to the Credit card number / Address name: https://screenshot.googleplex.com/7j1Ddh9TZAf
How does this look? Lighter gray or keep this one?
CC + Addresses.png
50.2 KB View Download
Color looks good (should be Paper Gray 660, #757575). Only feedback is that there should be 16px spacing between the credit card number and the "Google Payments" label. Thanks Hector!
Updated screenshot for "Google Payments"
screenshot.png
120 KB View Download
My guess is Alan may have feedback about the alignment, but I'm happy to launch as is. Thanks!
Sounds good, CL should land soon with this change.
Status: Fixed (was: Started)

Sign in to add a comment