New issue
Advanced search Search tips

Issue 607347 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 608079
issue 621659

Blocking:
issue 546836
issue 614588
issue 614589



Sign in to add a comment

[Autofill] Update Addresses to Material Design

Project Member Reported by hcarmona@chromium.org, Apr 27 2016

Issue description

Issue to track progress for this section.
 
Cc: bettes@chromium.org
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Passwords_forms.png%3Fz=width

Looks like Issue 488146 removed address book integration. Should we get rid of the "Include addresses from your Contacts card" check box? Or does this check box refer something else?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 28 2016

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83216ec07f04aa199a9de9a6e4a66c45696df84c

commit 83216ec07f04aa199a9de9a6e4a66c45696df84c
Author: hcarmona <hcarmona@chromium.org>
Date: Tue May 17 02:44:38 2016

Implement autofill Address and Credit Card lists.

This CL includes tests to verify UI.
Regenerates the private API in order to ensure closure compile.
API is not called to populate UI w/ real data, will be followup CL.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1947293002
Cr-Commit-Position: refs/heads/master@{#394032}

[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[add] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/chrome_tests.gypi
[add] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/83216ec07f04aa199a9de9a6e4a66c45696df84c/third_party/closure_compiler/externs/autofill_private.js

Project Member

Comment 4 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b609f48aa006b1fce36c7c9b1edd31cf766aca6c

commit b609f48aa006b1fce36c7c9b1edd31cf766aca6c
Author: hcarmona <hcarmona@chromium.org>
Date: Fri May 20 23:32:38 2016

Add context menus in md-setting for the address and credit card lists.

Menus will show/hide appropriately.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1992043002
Cr-Commit-Position: refs/heads/master@{#395199}

[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/app/settings_strings.grdp
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/b609f48aa006b1fce36c7c9b1edd31cf766aca6c/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f900222890dd7e4d6ca6ac872520b6ee9c518f04

commit f900222890dd7e4d6ca6ac872520b6ee9c518f04
Author: hcarmona <hcarmona@chromium.org>
Date: Mon May 23 23:29:21 2016

Separate the listeners and getters for the Autofill Private API.

OnAddressListChanged and OnCreditCardListChanged used to trigger an
update when a listener was added. This is now de-coupled so that a list
can be retrieved separately from listening for changes.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1957043002
Cr-Commit-Position: refs/heads/master@{#395462}

[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/chrome_tests.gypi
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/extensions/api_test/autofill_private/test.js
[add] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[add] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/f900222890dd7e4d6ca6ac872520b6ee9c518f04/tools/metrics/histograms/histograms.xml

Components: UI>Settings
Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-PasswordsForms
Labels: Pri-1
Labels: OS-All
Labels: Hotlist-MD-DevBlocker
Blocking: 614588
Blocking: 614589
Labels: -Hotlist-MD-DevBlocker
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea2730123956cc7cd538919573330f7c3dccb493

commit ea2730123956cc7cd538919573330f7c3dccb493
Author: hcarmona <hcarmona@chromium.org>
Date: Fri May 27 19:59:02 2016

Saved addresses and credit cards can be removed from md-settings.

BUG= 607348 , 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2008273003
Cr-Commit-Position: refs/heads/master@{#396544}

[modify] https://crrev.com/ea2730123956cc7cd538919573330f7c3dccb493/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/ea2730123956cc7cd538919573330f7c3dccb493/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Blockedon: 608079
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/132cb2dc5d841b0b25ad5580d02794614ba561f2

commit 132cb2dc5d841b0b25ad5580d02794614ba561f2
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Jun 10 22:50:43 2016

Update Autofill Private API to provide a list of available countries.

BUG= 607347 

Review-Url: https://codereview.chromium.org/2028903002
Cr-Commit-Position: refs/heads/master@{#399306}

[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_util.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_util.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/test/data/extensions/api_test/autofill_private/test.js
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/tools/metrics/histograms/histograms.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/132cb2dc5d841b0b25ad5580d02794614ba561f2

commit 132cb2dc5d841b0b25ad5580d02794614ba561f2
Author: hcarmona <hcarmona@chromium.org>
Date: Fri Jun 10 22:50:43 2016

Update Autofill Private API to provide a list of available countries.

BUG= 607347 

Review-Url: https://codereview.chromium.org/2028903002
Cr-Commit-Position: refs/heads/master@{#399306}

[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_api.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_private_apitest.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_util.cc
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/browser/extensions/api/autofill_private/autofill_util.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/chrome/test/data/extensions/api_test/autofill_private/test.js
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/third_party/closure_compiler/externs/autofill_private.js
[modify] https://crrev.com/132cb2dc5d841b0b25ad5580d02794614ba561f2/tools/metrics/histograms/histograms.xml

Screenshots for Add/Edit Address Dialog

CL: https://codereview.chromium.org/2079853002/
Add - Default.png
90.0 KB View Download
Add - Scrollbar.png
76.4 KB View Download
Edit - Namey.png
119 KB View Download
Looks good Hector! A couple things:
* Small nit, but the textfields' identation doesn't seem to match that of the dialog's title
* In the scrolling mock, there should be a 1px divider between the scroll area and the buttons when content is hidden (paper-dialog-scrollable implements that behavior)
Sounds good, I'll implement those changes and update the CL and screenshots
Blockedon: 621659
Updated screenshots based on tbuckley@'s feedback.

* Fixed text fields so they are aligned with title.
* Filed  Issue 621659  to fix the 1px divider on all dialogs.
new-empty.png
17.0 KB View Download
new-with-scrollbar.png
17.0 KB View Download
edit.png
39.8 KB View Download
from the background color on the Save button, I notice Save has more padding than Cancel, which makes the Save button look like it's abutting or overlapping the Cancel button. other dialogs in ToT look different, see screenshot.
Screenshot from 2016-06-21 13:31:04.png
66.0 KB View Download
Updated spacing between cancel/save buttons.
spacing.png
39.6 KB View Download
Cc: hcarmona@chromium.org
 Issue 623787  has been merged into this issue.
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b42531c9e81e485dadc15ee7320134c9aac202a

commit 7b42531c9e81e485dadc15ee7320134c9aac202a
Author: hcarmona <hcarmona@chromium.org>
Date: Tue Jun 28 22:48:45 2016

Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.

Screenshots of dialog in bug.

BUG= 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2079853002
Cr-Commit-Position: refs/heads/master@{#402580}

[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/app/settings_strings.grdp
[add] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[add] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a

commit ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a
Author: shans <shans@chromium.org>
Date: Wed Jun 29 05:14:01 2016

Revert of Add Edit/Create Address Dialog to MD Settings. (patchset #7 id:140001 of https://codereview.chromium.org/2079853002/ )

Reason for revert:
New tests are failing on https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/55180

Original issue's description:
> Add Edit/Create Address Dialog to MD Settings.
>
> Change includes lots of tests.
>
> Screenshots of dialog in bug.
>
> BUG= 607347 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a
> Cr-Commit-Position: refs/heads/master@{#402580}

TBR=michaelpg@chromium.org,hcarmona@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 607347 

Review-Url: https://codereview.chromium.org/2107093002
Cr-Commit-Position: refs/heads/master@{#402731}

[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/app/settings_strings.grdp
[delete] https://crrev.com/c9e6026a6a3ec5016f382953c408c9aa1a1bb0d5/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[delete] https://crrev.com/c9e6026a6a3ec5016f382953c408c9aa1a1bb0d5/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

 Issue 627642  has been merged into this issue.
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a206f090738b6e319eaa9caa1783687f636ed70

commit 3a206f090738b6e319eaa9caa1783687f636ed70
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Jul 13 21:42:36 2016

[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG= 607347 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2109233002
Cr-Commit-Position: refs/heads/master@{#405303}

[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/app/settings_strings.grdp
[add] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[add] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Project Member

Comment 31 by bugdroid1@chromium.org, Jul 15 2016

Status: Fixed (was: Started)
This section should now have feature parity with options.

Sign in to add a comment