New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607344 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

depot_tools presubmit fails on OS X

Project Member Reported by thakis@chromium.org, Apr 27 2016

Issue description

Just tried uploading a CL, and `git cl upload` died like so:

** Presubmit Warnings **
tests/git_common_test.py (13.77s) failed
..F....................F.......uCannot foo with a dirty tree. You must commit locally first.
Uncommitted files: (git diff-index --name-status HEAD)
A	test.file
.......
======================================================================
FAIL: testMakeWorkdir (__main__.GitMakeWorkdir)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 833, in testMakeWorkdir
    os.path.join(self.repo.repo_path, '.git', path))
AssertionError: '/private/var/folders/c5/8d7sdn1x2mg92mj0rndghhdr0000gn/T/git_repoRdkQFkbase/tmprVOD5v/.git/config' != '/var/folders/c5/8d7sdn1x2mg92mj0rndghhdr0000gn/T/git_repoRdkQFkbase/tmprVOD5v/.git/config'

======================================================================
FAIL: testRepoRoot (__main__.GitReadOnlyFunctionsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 340, in testRepoRoot
    self.assertEqual(self.repo.repo_path, self.repo.run(self.gc.repo_root))
AssertionError: '/var/folders/c5/8d7sdn1x2mg92mj0rndghhdr0000gn/T/git_repoRdkQFkbase/tmpTfAVZl' != '/private/var/folders/c5/8d7sdn1x2mg92mj0rndghhdr0000gn/T/git_repoRdkQFkbase/tmpTfAVZl'

----------------------------------------------------------------------
Ran 39 tests in 13.277s

FAILED (failures=2, unexpected successes=1)
Name         Stmts   Miss  Cover   Missing
------------------------------------------
git_common     437      0   100%   


tests/git_number_test.py (0.14s) failed
ERROR: python-coverage (3.7) is required to be installed on your PYTHONPATH to run this test.


tests/presubmit_unittest.py (4.76s) failed
..................................................................................................E...............E
======================================================================
ERROR: testExecPresubmitScript (__main__.PresubmitUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/thakis/src/depot_tools/third_party/pymox/mox.py", line 1618, in new_method
    func(self, *args, **kwargs)
  File "tests/presubmit_unittest.py", line 663, in testExecPresubmitScript
    fake_presubmit)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py", line 475, in assertRaises
    callableObj(*args, **kwargs)
  File "/Users/thakis/src/depot_tools/presubmit_support.py", line 1380, in ExecPresubmitScript
    self.rietveld, self.verbose)
  File "/Users/thakis/src/depot_tools/presubmit_support.py", line 323, in __init__
    self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/__init__.py", line 232, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 138, in __init__
    self._setup_queues()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 235, in _setup_queues
    self._outqueue = SimpleQueue()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 353, in __init__
    self._reader, self._writer = Pipe(duplex=False)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/__init__.py", line 107, in Pipe
    return Pipe(duplex)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/connection.py", line 196, in Pipe
    fd1, fd2 = os.pipe()
OSError: [Errno 24] Too many open files

======================================================================
ERROR: testTags (__main__.PresubmitUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/thakis/src/depot_tools/third_party/pymox/mox.py", line 1618, in new_method
    func(self, *args, **kwargs)
  File "tests/presubmit_unittest.py", line 913, in testTags
    change, False, True, output, input_buf, DEFAULT_SCRIPT, False, None))
  File "/Users/thakis/src/depot_tools/presubmit_support.py", line 1472, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(default_presubmit, fake_path)
  File "/Users/thakis/src/depot_tools/presubmit_support.py", line 1380, in ExecPresubmitScript
    self.rietveld, self.verbose)
  File "/Users/thakis/src/depot_tools/presubmit_support.py", line 323, in __init__
    self._run_tests_pool = multiprocessing.Pool(self.cpu_count)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/__init__.py", line 232, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 138, in __init__
    self._setup_queues()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/pool.py", line 235, in _setup_queues
    self._outqueue = SimpleQueue()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 353, in __init__
    self._reader, self._writer = Pipe(duplex=False)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/__init__.py", line 107, in Pipe
    return Pipe(duplex)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/connection.py", line 196, in Pipe
    fd1, fd2 = os.pipe()
OSError: [Errno 24] Too many open files

----------------------------------------------------------------------
Ran 115 tests in 1.902s

FAILED (errors=2)


tests/recipes_test.py (2.39s) failed
fatal: Needed a single revision
From https://chromium.googlesource.com/a/external/github.com/luci/recipes-py
   7d340be..d903931  master     -> origin/master
Traceback (most recent call last):
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipes.py", line 442, in <module>
    sys.exit(main())
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipes.py", line 406, in main
    return simulation_test(package_deps, args)
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipes.py", line 36, in simulation_test
    from recipe_engine import simulation_test
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipe_engine/simulation_test.py", line 12, in <module>
    from .third_party import expect_tests
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/__init__.py", line 5, in <module>
    from .main import main
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/main.py", line 9, in <module>
    from .cover import CoverageContext
  File "/Users/thakis/src/depot_tools/.recipe_deps/recipe_engine/recipe_engine/third_party/expect_tests/cover.py", line 10, in <module>
    import coverage
ImportError: No module named coverage
Traceback (most recent call last):
  File "tests/recipes_test.py", line 17, in <module>
    recipes_py('simulation_test')
  File "tests/recipes_test.py", line 15, in recipes_py
    subprocess.check_call([os.path.join(ROOT_DIR, 'recipes.py')] + list(args))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/Users/thakis/src/depot_tools/recipes.py', 'simulation_test']' returned non-zero exit status 1


Presubmit checks took 32.5s to calculate.

 
Cc: -iannucci@chromium.org aga...@chromium.org
Labels: -Infra
Owner: iannucci@chromium.org
Status: Assigned (was: Untriaged)
We don't have a label for depot_tools issues, so I'm going to assign this is Robbie and add Aaron to CC to remove it from infra untriaged queue.
Components: Infra>SDK
Infra>SDK is the component for depot_tools.

Comment 3 by aga...@chromium.org, Jun 28 2016

Components: -Infra>SDK Infra>Git
Infra>SDK is the component for user-facing bits of depot_tools, like gclient, git-cl, and hermetic git/python.

This is about the tests behind the scenes not working on specific platforms. I'd say this is Infra>Client>Infra, or Infra>Git (since the tests are from git_common.py).

But either way, I think Robbie is the most qualified to tackle this.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e434a4e3f39392fff4f5c908588a70ff81d26626

commit e434a4e3f39392fff4f5c908588a70ff81d26626
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 16 00:46:49 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/e38699bd9583c2ee9eb1436f3fc640cf97462722 Fix broken git tests on mac. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 607344 

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2250473003

[modify] https://crrev.com/e434a4e3f39392fff4f5c908588a70ff81d26626/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 16 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/4f77f2fa36ce027f3760ba2d678f716bf94e2906

commit 4f77f2fa36ce027f3760ba2d678f716bf94e2906
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Aug 16 01:07:27 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e434a4e3f39392fff4f5c908588a70ff81d26626 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/6e362607870ab3eae46cef835c492e1da2eb77c5 [Android] Surface --write-buildbot-json option of test_runner.py (perezju@chromium.org)
depot_tools:
  https://crrev.com/e38699bd9583c2ee9eb1436f3fc640cf97462722 Fix broken git tests on mac. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635877, 607344 

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2252433003

[modify] https://crrev.com/4f77f2fa36ce027f3760ba2d678f716bf94e2906/infra/config/recipes.cfg

Cc: iannucci@chromium.org
Components: -Infra>Git Infra>SDK
Owner: ----
Status: Available (was: Assigned)
It no longer fails JUST on OS X (it has tons of errors :(). Relabeling this as Infra>SDK as we have a bucket for that now. I'm also not presently working on this, so marking available.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
I don't think this is broken any more?

Sign in to add a comment