New issue
Advanced search Search tips

Issue 607333 link

Starred by 1 user
Status: Fixed
Owner:
btolsch@chromium.org
Closed: Apr 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Pseudo sinks shown for domains that can't use them.

Project Member Reported by btolsch@chromium.org, Apr 27 2016 
"Add a hangout" filter item should not be shown for users in a domain that doesn't support them. It will always fail to create a hangout.

Repro steps:
1. Logged in with an @gmail.com account, start typing into the Search box in the MR dialog. 
2. An "add a hangout" label appears underneath the box. Selecting it creates a failure msg.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8906da25102968ee173acbb234728902ae4bb03

commit b8906da25102968ee173acbb234728902ae4bb03
Author: btolsch <btolsch@chromium.org>
Date: Thu Apr 28 01:14:43 2016

Hide pseudo sinks when user has no hosted domain.

This change prevents users without a hosted domain (e.g. @gmail.com users) from
seeing the "Add a hangout" pseudo sink in the MR dialog filter view. Trying to
create a named hangout for them will always fail.

BUG= 607333 
R=amp@chromium.org, apacible@chromium.org

Review-Url: https://codereview.chromium.org/1920293004
Cr-Commit-Position: refs/heads/master@{#390266}

[modify] https://crrev.com/b8906da25102968ee173acbb234728902ae4bb03/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/b8906da25102968ee173acbb234728902ae4bb03/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/b8906da25102968ee173acbb234728902ae4bb03/chrome/test/data/webui/media_router/media_router_container_search_tests.js

Comment 2 by btolsch@chromium.org, Apr 28 2016

Status: Fixed (was: Started)
►

Sign in to add a comment