PerformanceEntries recorded before PerformanceObserver is disconnected are not delivered |
||||||
Issue descriptionVersion: 52.0.2718.0 canary (64-bit) OS: OSX What steps will reproduce the problem? (1) Enable experimental features flag (2) Load http://w3c-test.org/submissions/2884/performance-timeline/po-disconnect.html The failing test is: > observer.observe({entryTypes: ["mark"]}); > performance.mark("mark1"); > observer.disconnect(); The mark ("mark1") is recorded before the observer is disconnected but is never delivered. WIP W3C tests: - http://w3c-test.org/submissions/2884/performance-timeline/ - https://github.com/w3c/web-platform-tests/pull/2884
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32102c0baf205ff54cd16644ddd823a6cb6538f5 commit 32102c0baf205ff54cd16644ddd823a6cb6538f5 Author: panicker <panicker@chromium.org> Date: Mon May 09 22:06:01 2016 Fix an edge case where early disconnect() can omit delivering of observation. BUG= 607324 Review-Url: https://codereview.chromium.org/1945953002 Cr-Commit-Position: refs/heads/master@{#392436} [modify] https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5/third_party/WebKit/Source/core/timing/PerformanceBase.cpp [add] https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp [modify] https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp [modify] https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5/third_party/WebKit/Source/core/timing/PerformanceObserver.h
,
May 16 2016
,
Feb 24 2017
Based on discussion in [1], we should revert this behavior. [1] https://github.com/w3c/performance-timeline/issues/66#issuecomment-282396844
,
Jul 12 2017
,
Aug 8 2017
Ping? Is this behavior going to be reverted? It seems like the resolution was that disconnect() should *not* flush records and this bug should be reverted. We'd like to ship this API in Firefox but don't want to ship something that is incompatible with Chrome.
,
Aug 8 2017
Thanks for the ping. Nicolas, can you take a look? Marking this P1, as it's blocking Firefox from shipping.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7df7884ee789a33cd850c04d6d462aaacb6df9f0 commit 7df7884ee789a33cd850c04d6d462aaacb6df9f0 Author: Nicolas Pena <npm@chromium.org> Date: Wed Aug 09 04:53:40 2017 Revert flush behavior when disconnecting PerformanceObserver This CL reverts the flush behavior introduced in https://crrev.com/32102c0baf205ff54cd16644ddd823a6cb6538f5 This is reverted after upstream agreement that it is not really the desired behavior, and to align with Mozilla's behavior: https://github.com/w3c/performance-timeline/issues/66#issuecomment-282396844 Bug: chromium:607324 Change-Id: Ia38649f29f99d9c71f06da1a1a3318cc83a82e12 Reviewed-on: https://chromium-review.googlesource.com/606209 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#492826} [modify] https://crrev.com/7df7884ee789a33cd850c04d6d462aaacb6df9f0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7df7884ee789a33cd850c04d6d462aaacb6df9f0/third_party/WebKit/Source/core/timing/PerformanceBase.cpp [modify] https://crrev.com/7df7884ee789a33cd850c04d6d462aaacb6df9f0/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp [modify] https://crrev.com/7df7884ee789a33cd850c04d6d462aaacb6df9f0/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
,
Aug 11 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by panicker@chromium.org
, Apr 29 2016